Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement partial_derivative_scalar in Bivariate Base class #80

Closed
csala opened this issue Jan 8, 2019 · 0 comments
Closed

Implement partial_derivative_scalar in Bivariate Base class #80

csala opened this issue Jan 8, 2019 · 0 comments
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@csala
Copy link
Contributor

csala commented Jan 8, 2019

The method _partial_derivative is being used in the Vine classes:

https://github.com/DAI-Lab/Copulas/blob/57e4eb3a462e0ccffc25cc4bedd5a413304fe27a/copulas/multivariate/vine.py#L187

However, this method should is not intended to be called from outside the Bivariate copula classes (as it starts with an underscore), and is not implemented in all the Bivariate subclasses.

In order to fix this, the method should be moved to the Bivariate class and renamed to partial_derivative_scalar or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

No branches or pull requests

2 participants