Skip to content
This repository has been archived by the owner on Jan 4, 2021. It is now read-only.

Have other rights appear in groupless #5

Merged
merged 7 commits into from
Jul 6, 2016
Merged

Have other rights appear in groupless #5

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
921c670
Have other rights appear in groupless
mnoack Jul 4, 2016
41c1fb9
Don't define group, leave nil and let view display how it wants
mnoack Jul 5, 2016
c78b9a7
Collapse existing array building
mnoack Jul 5, 2016
998299c
Simplify code
mnoack Jul 5, 2016
cc26744
Break up complex methods
mnoack Jul 5, 2016
15fbfd3
Rails 5 support
mnoack Jul 5, 2016
0da1a97
Test rails 5 in travis
mnoack Jul 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/right_on/right.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ def by_groups
rights = []
rights += regular_rights_with_group
rights += restricted_rights_with_group
other_rights = Right.all - rights
other_rights.each { |right| right.group = 'Groupless' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just append the groupless rights to the end of the resulting array instead of introducing a hardcoded group name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe even clearer if we add a new method that just return the "groupless" rights.

rights += other_rights
rights.group_by(&:group)
end

Expand Down