This repository was archived by the owner on Nov 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Usage example for readme #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrii-balitskyi
commented
Jan 31, 2022
- usage example added to readme
- url added to ConnectWebview type
seveibar
suggested changes
Feb 2, 2022
README.md
Outdated
created_at: "2022-02-01T12:57:40.843Z", | ||
}, | ||
], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's more conventional to write
const accessCodeList = seam.accessCodes.list(someLockId)
console.log(accessCodeList)
/*
{
access_codes: [
{
access_code_id: "some-access-code-1",
name: "Some Access Code",
code: "1234",
type: "ongoing",
created_at: "2022-02-01T12:57:40.843Z",
},
],
}
*/
README.md
Outdated
```ts | ||
import Seam from seamapi | ||
|
||
// export SEAM_API_KEY=*** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// export SEAM_API_KEY=*** | |
// Seam will automatically use the SEAM_API_KEY environment variable if you | |
// don't provide an api_key to `new Seam()` |
seveibar
approved these changes
Feb 2, 2022
codetheweb
reviewed
Feb 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me!
README.md
Outdated
const someLock = seam.locks.list().devices[0] | ||
const someLockId = someLock.device_id | ||
|
||
seam.locks.lockDoor(someLockId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These API calls should be await
ed.
codetheweb
approved these changes
Feb 3, 2022
This was referenced Dec 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.