fix: device lock status disappearing when unlocked #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewuu
requested review from
kadiryazici and
razor-x
and removed request for
dawnho and
razor-x
Contributor
Author
|
Discussed in thread: https://hello-seam.slack.com/archives/C05FXN0QYH0/p1759185704232699 |
razor-x
reviewed
Oct 8, 2025
Member
There was a problem hiding this comment.
useLockDoor/useUnlockDoor / use-(un)lock-door.ts
Contributor
Author
There was a problem hiding this comment.
src/lib/seam/components/DeviceDetails/LockDeviceLockButtons.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
131
to
157
| return ( | ||
| <div className='seam-content seam-lock-status'> | ||
| <div> | ||
| <span className='seam-label'>{t.lockStatus}</span> | ||
| <span className='seam-value'>{t.statusUnknown}</span> | ||
| </div> | ||
| <div className='seam-right'> | ||
| <Button | ||
| size='small' | ||
| onClick={() => { | ||
| lock.mutate(device) | ||
| }} | ||
| > | ||
| {t.lock} | ||
| </Button> | ||
| <Button | ||
| size='small' | ||
| onClick={() => { | ||
| unlock.mutate(device) | ||
| }} | ||
| > | ||
| {t.unlock} | ||
| </Button> | ||
| </div> | ||
| </div> | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
For this last condition
Cannot lock or unlock = show unknown status + both lock/unlock buttons
We should not show ANY buttons or any row. If cannot lock or unlock then the buttons are not going to work.
Contributor
Author
There was a problem hiding this comment.
makes sense, thanks!
Co-authored-by: Evan Sosenko <evan@getseam.com>
panzerchris
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/seam/issue/CX-450/status-field-disappears-when-clicking-unlock-button-in-seam-components
Previously we were hiding the toggle to prevent the case where the device doesn't report lock status.
This PR conditionally renders buttons depending on whether the device has capability to unlock/lock:
Screenshots