Remove unnecessary indirection via dom()-method

unifies the access pattern, as some places where already directly working with the property, while others accessed it via dom()

Author: staabm

src/Report/Xml/File.php

@@ -18,7 +18,7 @@
  */
 class File
 {
-    private readonly DOMDocument $dom;
+    protected readonly DOMDocument $dom;
     private readonly DOMElement $contextNode;
 
     public function __construct(DOMElement $context)
@@ -77,9 +77,4 @@ protected function contextNode(): DOMElement
     {
         return $this->contextNode;
     }
-
-    protected function dom(): DOMDocument
-    {
-        return $this->dom;
-    }
 }

src/Report/Xml/Node.php

@@ -18,7 +18,7 @@
  */
 abstract class Node
 {
-    private readonly DOMDocument $dom;
+    protected readonly DOMDocument $dom;
     private readonly DOMElement $contextNode;
 
     public function __construct(DOMElement $context)
@@ -27,11 +27,6 @@ public function __construct(DOMElement $context)
         $this->contextNode = $context;
     }
 
-    public function dom(): DOMDocument
-    {
-        return $this->dom;
-    }
-
     public function totals(): Totals
     {
         $totalsContainer = $this->contextNode()->firstChild;
@@ -52,7 +47,7 @@ public function totals(): Totals
 
     public function addDirectory(string $name): Directory
     {
-        $dirNode = $this->dom()->createElementNS(
+        $dirNode = $this->dom->createElementNS(
             Facade::XML_NAMESPACE,
             'directory',
         );
@@ -65,7 +60,7 @@ public function addDirectory(string $name): Directory
 
     public function addFile(string $name, string $href): File
     {
-        $fileNode = $this->dom()->createElementNS(
+        $fileNode = $this->dom->createElementNS(
             Facade::XML_NAMESPACE,
             'file',
         );

src/Report/Xml/Project.php

@@ -42,14 +42,14 @@ public function projectSourceDirectory(): string
 
     public function buildInformation(): BuildInformation
     {
-        $buildNode = $this->dom()->getElementsByTagNameNS(
+        $buildNode = $this->dom->getElementsByTagNameNS(
             Facade::XML_NAMESPACE,
             'build',
         )->item(0);
 
         if ($buildNode === null) {
-            $buildNode = $this->dom()->documentElement->appendChild(
-                $this->dom()->createElementNS(
+            $buildNode = $this->dom->documentElement->appendChild(
+                $this->dom->createElementNS(
                     Facade::XML_NAMESPACE,
                     'build',
                 ),
@@ -70,7 +70,7 @@ public function tests(): Tests
 
         if ($testsNode === null) {
             $testsNode = $this->contextNode()->appendChild(
-                $this->dom()->createElementNS(
+                $this->dom->createElementNS(
                     Facade::XML_NAMESPACE,
                     'tests',
                 ),
@@ -86,6 +86,6 @@ public function asDom(): DOMDocument
     {
         $this->contextNode()->setAttribute('source', $this->directory);
 
-        return $this->dom();
+        return $this->dom;
     }
 }

src/Report/Xml/Report.php

@@ -42,7 +42,7 @@ public function asDom(): DOMDocument
         $this->contextNode()->setAttribute('name', basename($this->name));
         $this->contextNode()->setAttribute('path', dirname($this->name));
 
-        return $this->dom();
+        return $this->dom;
     }
 
     public function functionObject(
@@ -56,7 +56,7 @@ public function functionObject(
         string $crap
     ): void {
         $node = $this->contextNode()->appendChild(
-            $this->dom()->createElementNS(
+            $this->dom->createElementNS(
                 Facade::XML_NAMESPACE,
                 'function',
             ),
@@ -86,7 +86,7 @@ public function classObject(
         float $crap
     ): Unit {
         $node = $this->contextNode()->appendChild(
-            $this->dom()->createElementNS(
+            $this->dom->createElementNS(
                 Facade::XML_NAMESPACE,
                 'class',
             ),
@@ -106,7 +106,7 @@ public function traitObject(
         float $crap
     ): Unit {
         $node = $this->contextNode()->appendChild(
-            $this->dom()->createElementNS(
+            $this->dom->createElementNS(
                 Facade::XML_NAMESPACE,
                 'trait',
             ),
@@ -126,7 +126,7 @@ public function source(): Source
 
         if ($source === null) {
             $source = $this->contextNode()->appendChild(
-                $this->dom()->createElementNS(
+                $this->dom->createElementNS(
                     Facade::XML_NAMESPACE,
                     'source',
                 ),