Upgraded bootstrap, jquery and popper

[GrahamCampbell]

• Bootstrap 4.3.1 (https://github.com/twbs/bootstrap/releases/download/v4.3.1/bootstrap-4.3.1-dist.zip)
• jQuery 3.4.1 (https://code.jquery.com/jquery-3.4.1.min.js)
• popper 1.15.0 (https://raw.githubusercontent.com/FezVrasta/popper.js/v1.15.0/dist/popper.min.js)

[codecov]

Codecov Report

Merging #694 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #694   +/-   ##
=========================================
  Coverage     85.05%   85.05%           
  Complexity      813      813           
=========================================
  Files            32       32           
  Lines          2476     2476           
=========================================
  Hits           2106     2106           
  Misses          370      370

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7743bbc...b348d34. Read the comment docs.

[sebastianbergmann]

With this patch the popin for "which line covers this test" no longer works.

[GrahamCampbell]

Whoops. Give me a sec to double check which version we upgraded from, so I can see what's changed upstream to cause this.

[GrahamCampbell]

[GrahamCampbell]

Well, they claim to have made no breaking changes between 1.14.3 and 1.15.0... https://github.com/FezVrasta/popper.js/releases

[sebastianbergmann]

Updating Bootstrap to 4.3.1 and jQuery to 3.4.1 does not break the popin. It is the update to popper 1.15.0 that does.

[DanielRuf]

Hi @GrahamCampbell,

your PR uses the ESM version which does not work in this setup.

The UMD version does work.
https://unpkg.com/popper.js@1.15.0/dist/umd/popper.min.js

Can you replace it?

[sebastianbergmann]

Thank you, @DanielRuf, I have updated popper.js in d0f4b07.

[GrahamCampbell]

Great.