BitField->reverse(self,val) reverses order of fields... why?

[Crossfire55555]

Is there a bug in BitField's reverse()? I have a very unusual cookie that I am trying to make. All the fields are BitFields. Here is the test class I made for easier testing

First with Reverse() active

This give the output of the types in reverse order

now without reverse active

This is the correct output that I was expecting

Im using 2.3.3.dev511. I understand that reverse if for systems with a particular endianess but this seems to be resulting a bug where it doesnt reverse the string. Thought I should bring this to your attention since it took me forever to figure out what was going on.

[Crossfire55555]

update: Without reverse the order is still scrambled.

any ideas as to how to make this work properly?

[p-l-]

Please avoid screenshots as we cannot copy & paste your code, and use proper markdown formatting instead. Thanks!

[Crossfire55555]

Sorry about that, this is my actual code that im trying to implement. But the bitfields are screwing up the order of the fields. in this case when I make a generic a=MPCookie() and run a.show() then it orders it as Reserved, StreamNumber, ReorderID, parcel_type. when I use str(a) the bits are not in the order I would expect. Any idea what is going on? I have looked in several other layers that use bitfields and I dont see them doing anything special

class MPCookie(Packet):
    name = "MPCookie "
    fields_desc = { BitEnumField("parcel_type", 0, 4, _mp_parcel_type),
                    BitField("ReorderID", 0, 13),
                    BitField("StreamNumber", 0, 11),
                    ConditionalField(BitField("Reserved", 0, 4)
                        ,lambda p:p.parcel_type!=1),
                    ConditionalField(BitField("Reserved", 0, 6)
                        ,lambda p:p.parcel_type==1),
                    ConditionalField(BitFieldLenField("PacketLength", None, 14)
                        ,lambda p:p.parcel_type==1),
                    ConditionalField(ShortField("Reserved2", 0)
                        ,lambda p:p.parcel_type==1),
                    ConditionalField(LongField("TailHandle", 0)
                        ,lambda p:p.parcel_type==1),
                  }

[Crossfire55555]

I am asking this question in a little more refined way in a different

[p-l-]

Please use simple and reproducible examples: we need _mp_parcel_type defined here.

You are using sets ({...}) instead of lists ([...]) for fields_desc. Sets are unordered. Use lists and your code should work as expected.

[Crossfire55555]

.... once again defeated again by lack of knowledge of python! Thank you so much @p-l- I was about to rewrite the addfield and getfield function. Thanks for the quick help and explanation