Automotive documentation and Typing [ready] #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3075 +/- ##
==========================================
+ Coverage 85.03% 85.32% +0.28%
==========================================
Files 265 265
Lines 54956 54962 +6
==========================================
+ Hits 46732 46896 +164
+ Misses 8224 8066 -158
|
|
Uuups appveyor got canceled. |
|
@gpotter2 This PR is ready for review |
|
Thanks for the PR. I'd however like for the |
|
Alright, no problem. |
polybassa
force-pushed
the
Automotive_documentation
branch
from
50d65da
to
90ea22d
Compare
|
waiting for #3059 |
polybassa
force-pushed
the
Automotive_documentation
branch
from
07d4c9e
to
2e9c37c
Compare
polybassa
force-pushed
the
Automotive_documentation
branch
from
2e9c37c
to
8424f02
Compare
|
@gpotter2 Rebased and ready for review. This PR changes the typing of |
|
The typing of select is changed in #3090 too. You can probably rebase on top of it in the meantime :/ |
gpotter2
reviewed
Mar 2, 2021
polybassa
force-pushed
the
Automotive_documentation
branch
from
bbc3814
to
6a0d365
Compare
|
Sorry for the delay. I'm waiting for 2.4.5.. |
polybassa
force-pushed
the
Automotive_documentation
branch
from
6a0d365
to
8078fc2
Compare
|
@gpotter2 Rebased. |
polybassa
force-pushed
the
Automotive_documentation
branch
from
bd47d4b
to
0a90098
Compare
…w and add remove-padding configuration to CAN
gpotter2
force-pushed
the
Automotive_documentation
branch
from
674fad6
to
d4c8777
Compare
gpotter2
approved these changes
Apr 22, 2021
| @@ -100,6 +100,9 @@ | |||
| # Enable codeauthor and sectionauthor directives | |||
| show_authors = True | |||
|
|
|||
| # Mock python-can | |||
| autodoc_mock_imports = ["can"] | |||
There was a problem hiding this comment.
Good job for finding this out, I didn't know it was builtin.
|
Can this PR get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started a new series of documentation improvements.
This PR improves the API documentation of CAN and PythonCANSockets and adds typing to CAN, PythonCANSockets and NativeCANSockets