Isotp typing [ready]

[polybassa]

No description provided.

[codecov]

Codecov Report

Merging #3078 (5dec200) into master (18b71dd) will decrease coverage by 0.01%.
The diff coverage is 65.26%.

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
- Coverage   85.32%   85.30%   -0.02%     
==========================================
  Files         262      262              
  Lines       54731    54742      +11     
==========================================
+ Hits        46697    46699       +2     
- Misses       8034     8043       +9     

Impacted Files	Coverage Δ
scapy/compat.py	95.42% <ø> (ø)
scapy/contrib/automotive/kwp.py	95.34% <ø> (ø)
scapy/fields.py	91.38% <ø> (ø)
scapy/contrib/isotp.py	69.17% <62.98%> (-0.63%)	⬇️
scapy/sessions.py	94.85% <66.66%> (+1.07%)	⬆️
scapy/contrib/automotive/gm/gmlanutils.py	90.00% <100.00%> (+1.73%)	⬆️
scapy/arch/windows/__init__.py	67.73% <0.00%> (-0.57%)	⬇️

[gpotter2]

I'll likely go over it again. I expect this to break when the sndrcv PR is merged.

[polybassa]

I'll likely go over it again. I expect this to break when the sndrcv PR is merged.

Yes, I saw a couple of nice changes in sendrcv core typing. Looking forward to have them in.

[polybassa]

waiting for #3059

[polybassa]

@gpotter2 Rebased and ready for merge

[polybassa]

@gpotter2 Rebased.

[polybassa]

Thanks for your feedback.. I will apply it :-)

[polybassa]

Applied all feedback, except recv_raw related comments. Is it possible to break the return type of mypy into multiple lines?

[gpotter2]

Applied all feedback, except recv_raw related comments. Is it possible to break the return type of mypy into multiple lines?

Not using Python 2 typing format. That's annoying for sure

[polybassa]

Hi, thanks for this feedback. No worries ;-)
So, just to get your request right.

At the moment, the code looks like this:

    def recv_raw(self, x=MTU):
        # type: (int) -> Tuple[Optional[Type[Packet]], Optional[bytes], Optional[float]]  # noqa: E501

scapy/scapy/supersocket.py

Lines 166 to 167 in 4bec6ee

	def recv_raw(self, x=MTU):
	# type: (int) -> Tuple[Optional[Type[Packet]], Optional[bytes], Optional[float]] # noqa: E501

And you request to change it to

    def recv_raw(self,
                          x=MTU  # type: int
                          ):
        # type: (...) -> Tuple[Optional[Type[Packet]], Optional[bytes], Optional[float]]  # noqa: E501

I just wanted to get this right, since I thought the intention of the multiline typing is to save noqa's, which would not be the case in this change.

Thanks for your support!

I've resend this answer to have markdown support.
@gpotter2 Could you please give me feedback on this question

[gpotter2]

Conflicts otherwise lgtm

[gpotter2]

Sorry for the late answer polybassa, to answer your question, you are right that in this case (return type takes most of the space) it makes more sense to stay single line.

I've fixed the conflicts