Cleaned up and edit custom proxy instructions #1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markzegarelli
requested review from
stayseesong
and removed request for
a team
|
✔️ Deploy Preview for segment-docs ready! 🔨 Explore the source changes: 175822d 🔍 Inspect the deploy log: https://app.netlify.com/sites/segment-docs/deploys/6160cc109456ef0008a81326 😎 Browse the preview: https://deploy-preview-1986--segment-docs.netlify.app |
|
Hi @pooyaj, as discussed on Slack, I've cleaned up the A.js Custom Proxy doc. As the CloudFront UI has changed quite a bit, can you have a look to see if there is anything missing? |
markzegarelli
added
content
stayseesong
reviewed
Oct 11, 2021
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
stayseesong
requested changes
Oct 11, 2021
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/website/javascript/custom-proxy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
stayseesong
approved these changes
Oct 13, 2021
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge timing
Standard
Related issues (optional)
Closes #1975
Closes #1977