[byteplus] adding new destination folder in order to show new name in… #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcgilbert
requested review from
forstisabella,
markzegarelli and
a team
and removed request for
a team
forstisabella
added
the
fixed-site
markzegarelli
approved these changes
Feb 1, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
markzegarelli
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Adding admonition infrastructure * DOC-393 Taking it out of an admonition format and adding it to the paragraph above it * [DOC-393] Simplifying the information, adding it to the sentence before it * Fixes to Contributing page * small update to ga4 * Update CONTRIBUTING.md Frontmatter -> Front matter * Add note about Criteo connection modes with Analytics.js (#2437) * Add clarity to HubSpot API limit (#2436) * Update CONTRIBUTING.md * catalog update * Add Troubleshooting section to GEC docs (#2434) * add Troubleshooting section to GEC docs * style edits Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * redirect sprig actions (#2423) * remove connection table * Linking to FQL from Destination Filters doc (#2421) * Linking to FQL from Destination Filters doc * Update src/connections/destinations/destination-filters.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> * [byteplus] adding new destination folder in order to show new name in… (#2414) * [byteplus] adding new destination folder in order to show new name in docs URL * local links should be relative Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * Add region unsupported message for all cloud sources (#2422) * Add region unsupported message for all cloud sources * Remove spaces * prettify markdown * copy edits Co-authored-by: markzegarelli <mark.zegarelli@segment.com> Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> Co-authored-by: pwseg <paul.wooley@segment.com> Co-authored-by: Segment Docs Robot <73141528+bot-docsteam@users.noreply.github.com> Co-authored-by: kdaswani <49517136+kdaswani@users.noreply.github.com> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com> Co-authored-by: Niall Brennan <niall.brennan@segment.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com> Co-authored-by: jinapark202 <87985289+jinapark202@users.noreply.github.com>
markzegarelli
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Adding admonition infrastructure * DOC-393 Taking it out of an admonition format and adding it to the paragraph above it * [DOC-393] Simplifying the information, adding it to the sentence before it * Fixes to Contributing page * small update to ga4 * Update CONTRIBUTING.md Frontmatter -> Front matter * Add note about Criteo connection modes with Analytics.js (#2437) * Add clarity to HubSpot API limit (#2436) * Update CONTRIBUTING.md * catalog update * Add Troubleshooting section to GEC docs (#2434) * add Troubleshooting section to GEC docs * style edits Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * redirect sprig actions (#2423) * remove connection table * Linking to FQL from Destination Filters doc (#2421) * Linking to FQL from Destination Filters doc * Update src/connections/destinations/destination-filters.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> * [byteplus] adding new destination folder in order to show new name in… (#2414) * [byteplus] adding new destination folder in order to show new name in docs URL * local links should be relative Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * Add region unsupported message for all cloud sources (#2422) * Add region unsupported message for all cloud sources * Remove spaces * prettify markdown * copy edits Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * Friendbuy cloud destination (#2416) * Apply Friendbuy web destination documentation rename from master branch. * Copy Friendbuy web destination documentation as basis for cloud destination. * Update to Friendbuy web destination documentation. * Documentation for new Friendbuy cloud destination. * Apply suggestions from code review Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * Minor language tweaks. * Changed "might" to "probably" because it's unlikely that someone using both Friendbuy and Segment wouldn't use the Friendbuy web destination. * Changed "won't load" to "won't be loaded" because whether our JavaScript is loaded or not is outside of its control. Segment does not call the web destination's initialization function unless at least one mapping is enabled. * Move the Friendbuy web destination documentation back to actions-friendbuy. Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * update catalog Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> Co-authored-by: pwseg <paul.wooley@segment.com> Co-authored-by: Segment Docs Robot <73141528+bot-docsteam@users.noreply.github.com> Co-authored-by: kdaswani <49517136+kdaswani@users.noreply.github.com> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com> Co-authored-by: Niall Brennan <niall.brennan@segment.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com> Co-authored-by: jinapark202 <87985289+jinapark202@users.noreply.github.com> Co-authored-by: David Hull <david.hull@friendbuy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Creating a new destinations folder in order that the name shown in the documentation URL is updated from the following:
Merge timing
asap
Related issues (optional)
This is related to the datarangers documentation. Details that informed this change came from a conversation in slack: https://segment.slack.com/archives/CD3LFFTFZ/p1643219438019100
I believe I got the redirection part right, but please notify me otherwise.