Skip to content

Friendbuy Actions destinations #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Feb 1, 2022
Merged

Friendbuy Actions destinations #2445

merged 32 commits into from
Feb 1, 2022

Conversation

markzegarelli
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

forstisabella and others added 30 commits January 26, 2022 12:00
Frontmatter -> Front matter
Adding note about cookie compatibility/utility plugin [DOC-393]
* add Troubleshooting section to GEC docs

* style edits

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
Docs Contributing guide edits
* Linking to FQL from Destination Filters doc

* Update src/connections/destinations/destination-filters.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
…logic

Remove incorrect connection mode logic
#2414)

* [byteplus] adding new destination folder in order to show new name in docs URL

* local links should be relative

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
* Add region unsupported message for all cloud sources

* Remove spaces

* prettify markdown

* copy edits

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
* Apply Friendbuy web destination documentation rename from master branch.

* Copy Friendbuy web destination documentation as basis for cloud destination.

* Update to Friendbuy web destination documentation.

* Documentation for new Friendbuy cloud destination.

* Apply suggestions from code review

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* Minor language tweaks.

* Changed "might" to "probably" because it's unlikely that someone using
  both Friendbuy and Segment wouldn't use the Friendbuy web destination.

* Changed "won't load" to "won't be loaded" because whether our JavaScript
  is loaded or not is outside of its control. Segment does not call the web
  destination's initialization function unless at least one mapping is
  enabled.

* Move the Friendbuy web destination documentation back to actions-friendbuy.

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@markzegarelli markzegarelli requested a review from a team as a code owner February 1, 2022 23:08
@markzegarelli markzegarelli requested review from rchinn1 and removed request for a team February 1, 2022 23:08
@markzegarelli markzegarelli changed the base branch from develop to master February 1, 2022 23:09
@markzegarelli markzegarelli merged commit ccedea4 into master Feb 1, 2022
@markzegarelli markzegarelli deleted the friendbuy-deploy branch February 1, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants