Skip to content

Update documentation on CSP #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Update documentation on CSP #4248

merged 1 commit into from
Feb 23, 2023

Conversation

sarahrudy
Copy link
Contributor

Proposed changes

  • Add whitelisting approved domains
  • Add info section about support we're able to provide around CSP issues

Merge timing

  • ASAP once approved?

Related issues (optional)

N/A

- Add whitelisting approved domains
- Add info section about support we're able to provide around CSP issues
@sarahrudy sarahrudy added the KCS label Feb 16, 2023
@sarahrudy sarahrudy requested a review from a team as a code owner February 16, 2023 21:13
@sarahrudy sarahrudy requested review from pwseg and removed request for a team February 16, 2023 21:13
Copy link
Contributor

@pwseg pwseg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the small allowlist/whitelist thing to fix. Thanks!

@pwseg pwseg added the content-update updates to content that are not new features, includes grammar fixes, added notes label Feb 16, 2023
@sarahrudy
Copy link
Contributor Author

Thank you, @pwseg!

@markzegarelli markzegarelli merged commit 3e6314d into develop Feb 23, 2023
@markzegarelli markzegarelli deleted the sarahrudy-patch-9 branch February 23, 2023 18:06
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request Feb 23, 2023
* Update quickstart.md

* Update index.md

* Update quickstart.md

* Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* add event names that TikTok supports

TikTok doesn't support all event names, just their standard ones: https://ads.tiktok.com/marketing_api/docs?id=1727541103358977). This update makes customers aware of that.

* Remove location data

Remove location data form common fields as no library automatically collects this info.

* add docs for formsort

* converting table from html -> md

* table spacing

* Apply suggestions from code review

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* add info about warehouse snake_casing

* adding context to FAQ section for redshift serverless

we do not support redshift servless and adding context in the FAQ section

* Update common.md

* update ajs classic banner with upgrade timeline

* Adding qualtircs source documentation (#4241)

* Adding qualtircs source documentation

* a few miscellaneous edits

* Apply suggestions from code review

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

---------

Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* Add FAQ about failure notifications for audience and trait syncs (#4261)

* excessive notifications for aud/trait failures

Added relevant details for excessive notifications for audience/trait failures

* Update faqs.md

---------

Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com>

* Update src/connections/destinations/catalog/tiktok-conversions/index.md

* Update src/connections/storage/warehouses/schema.md

* Update src/connections/sources/catalog/cloud-apps/formsort/index.md

* catalog (#4268)

* Update common.md

* unhide docs (#4272)

* add id so mappings can be loaded (#4271)

* Update common.md

* Update src/connections/storage/catalog/redshift/index.md

* unhide qualtrics source docs

* Update common.md (#4281)

* Update common.md

* update link and passive > active voice

* Update Product limits (#4277)

* updates

* Update src/connections/rate-limits.md

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

---------

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* Update documentation on CSP (#4248)

- Add whitelisting approved domains
- Add info section about support we're able to provide around CSP issues

* Push screen method into supportedMethods (#4274)

* Catalog update (#4286)

---------

Co-authored-by: deepdel <45295303+deepdel@users.noreply.github.com>
Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: Spencer Attick <23665784+spencerattick@users.noreply.github.com>
Co-authored-by: Niall Brennan <niallbrennan87@gmail.com>
Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com>
Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: Carl Lee <104832011+carlmlee@users.noreply.github.com>
Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com>
Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com>
Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com>
Co-authored-by: david morton <110892780+daveo237@users.noreply.github.com>
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>
markzegarelli pushed a commit that referenced this pull request Feb 28, 2023
* Subscription SQL Public Beta

* [netlify-build]

* edits [netlify-build]

* Nav updates

* Feedback from Engineer

* Update src/engage/user-subscriptions/subscription-sql.md

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* Feedback from PM

* apply suggestions from code review

* Update CSV nav

* Release 23.8.2 (#4287)

* Update quickstart.md

* Update index.md

* Update quickstart.md

* Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* add event names that TikTok supports

TikTok doesn't support all event names, just their standard ones: https://ads.tiktok.com/marketing_api/docs?id=1727541103358977). This update makes customers aware of that.

* Remove location data

Remove location data form common fields as no library automatically collects this info.

* add docs for formsort

* converting table from html -> md

* table spacing

* Apply suggestions from code review

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* add info about warehouse snake_casing

* adding context to FAQ section for redshift serverless

we do not support redshift servless and adding context in the FAQ section

* Update common.md

* update ajs classic banner with upgrade timeline

* Adding qualtircs source documentation (#4241)

* Adding qualtircs source documentation

* a few miscellaneous edits

* Apply suggestions from code review

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

---------

Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* Add FAQ about failure notifications for audience and trait syncs (#4261)

* excessive notifications for aud/trait failures

Added relevant details for excessive notifications for audience/trait failures

* Update faqs.md

---------

Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com>

* Update src/connections/destinations/catalog/tiktok-conversions/index.md

* Update src/connections/storage/warehouses/schema.md

* Update src/connections/sources/catalog/cloud-apps/formsort/index.md

* catalog (#4268)

* Update common.md

* unhide docs (#4272)

* add id so mappings can be loaded (#4271)

* Update common.md

* Update src/connections/storage/catalog/redshift/index.md

* unhide qualtrics source docs

* Update common.md (#4281)

* Update common.md

* update link and passive > active voice

* Update Product limits (#4277)

* updates

* Update src/connections/rate-limits.md

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

---------

Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>

* Update documentation on CSP (#4248)

- Add whitelisting approved domains
- Add info section about support we're able to provide around CSP issues

* Push screen method into supportedMethods (#4274)

* Catalog update (#4286)

---------

Co-authored-by: deepdel <45295303+deepdel@users.noreply.github.com>
Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: Spencer Attick <23665784+spencerattick@users.noreply.github.com>
Co-authored-by: Niall Brennan <niallbrennan87@gmail.com>
Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com>
Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: Carl Lee <104832011+carlmlee@users.noreply.github.com>
Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com>
Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com>
Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com>
Co-authored-by: david morton <110892780+daveo237@users.noreply.github.com>
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>

* catalog update

---------

Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Co-authored-by: deepdel <45295303+deepdel@users.noreply.github.com>
Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: Spencer Attick <23665784+spencerattick@users.noreply.github.com>
Co-authored-by: Niall Brennan <niallbrennan87@gmail.com>
Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com>
Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM>
Co-authored-by: Carl Lee <104832011+carlmlee@users.noreply.github.com>
Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com>
Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com>
Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com>
Co-authored-by: david morton <110892780+daveo237@users.noreply.github.com>
Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes KCS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants