Add channel field to Common spec #4281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markzegarelli
changed the title
markzegarelli
approved these changes
Feb 23, 2023
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
markzegarelli
pushed a commit
that referenced
this pull request
Feb 23, 2023
* Update quickstart.md * Update index.md * Update quickstart.md * Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> * add event names that TikTok supports TikTok doesn't support all event names, just their standard ones: https://ads.tiktok.com/marketing_api/docs?id=1727541103358977). This update makes customers aware of that. * Remove location data Remove location data form common fields as no library automatically collects this info. * add docs for formsort * converting table from html -> md * table spacing * Apply suggestions from code review Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> * add info about warehouse snake_casing * adding context to FAQ section for redshift serverless we do not support redshift servless and adding context in the FAQ section * Update common.md * update ajs classic banner with upgrade timeline * Adding qualtircs source documentation (#4241) * Adding qualtircs source documentation * a few miscellaneous edits * Apply suggestions from code review Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> --------- Co-authored-by: rchinn-segment <ryan.chinn@segment.com> Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * Add FAQ about failure notifications for audience and trait syncs (#4261) * excessive notifications for aud/trait failures Added relevant details for excessive notifications for audience/trait failures * Update faqs.md --------- Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com> * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Update src/connections/storage/warehouses/schema.md * Update src/connections/sources/catalog/cloud-apps/formsort/index.md * catalog (#4268) * Update common.md * unhide docs (#4272) * add id so mappings can be loaded (#4271) * Update common.md * Update src/connections/storage/catalog/redshift/index.md * unhide qualtrics source docs * Update common.md (#4281) * Update common.md * update link and passive > active voice * Update Product limits (#4277) * updates * Update src/connections/rate-limits.md Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> --------- Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * Update documentation on CSP (#4248) - Add whitelisting approved domains - Add info section about support we're able to provide around CSP issues * Push screen method into supportedMethods (#4274) * Catalog update (#4286) --------- Co-authored-by: deepdel <45295303+deepdel@users.noreply.github.com> Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: Spencer Attick <23665784+spencerattick@users.noreply.github.com> Co-authored-by: Niall Brennan <niallbrennan87@gmail.com> Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com> Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com> Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com> Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> Co-authored-by: Carl Lee <104832011+carlmlee@users.noreply.github.com> Co-authored-by: rchinn-segment <ryan.chinn@segment.com> Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com> Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com> Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com> Co-authored-by: david morton <110892780+daveo237@users.noreply.github.com> Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com> Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>
markzegarelli
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Subscription SQL Public Beta * [netlify-build] * edits [netlify-build] * Nav updates * Feedback from Engineer * Update src/engage/user-subscriptions/subscription-sql.md Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com> * Feedback from PM * apply suggestions from code review * Update CSV nav * Release 23.8.2 (#4287) * Update quickstart.md * Update index.md * Update quickstart.md * Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * Update src/connections/destinations/catalog/actions-hubspot-cloud/index.md Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> * add event names that TikTok supports TikTok doesn't support all event names, just their standard ones: https://ads.tiktok.com/marketing_api/docs?id=1727541103358977). This update makes customers aware of that. * Remove location data Remove location data form common fields as no library automatically collects this info. * add docs for formsort * converting table from html -> md * table spacing * Apply suggestions from code review Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> * add info about warehouse snake_casing * adding context to FAQ section for redshift serverless we do not support redshift servless and adding context in the FAQ section * Update common.md * update ajs classic banner with upgrade timeline * Adding qualtircs source documentation (#4241) * Adding qualtircs source documentation * a few miscellaneous edits * Apply suggestions from code review Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> --------- Co-authored-by: rchinn-segment <ryan.chinn@segment.com> Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * Add FAQ about failure notifications for audience and trait syncs (#4261) * excessive notifications for aud/trait failures Added relevant details for excessive notifications for audience/trait failures * Update faqs.md --------- Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com> * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Update src/connections/storage/warehouses/schema.md * Update src/connections/sources/catalog/cloud-apps/formsort/index.md * catalog (#4268) * Update common.md * unhide docs (#4272) * add id so mappings can be loaded (#4271) * Update common.md * Update src/connections/storage/catalog/redshift/index.md * unhide qualtrics source docs * Update common.md (#4281) * Update common.md * update link and passive > active voice * Update Product limits (#4277) * updates * Update src/connections/rate-limits.md Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> --------- Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> * Update documentation on CSP (#4248) - Add whitelisting approved domains - Add info section about support we're able to provide around CSP issues * Push screen method into supportedMethods (#4274) * Catalog update (#4286) --------- Co-authored-by: deepdel <45295303+deepdel@users.noreply.github.com> Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: Spencer Attick <23665784+spencerattick@users.noreply.github.com> Co-authored-by: Niall Brennan <niallbrennan87@gmail.com> Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com> Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com> Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com> Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> Co-authored-by: Carl Lee <104832011+carlmlee@users.noreply.github.com> Co-authored-by: rchinn-segment <ryan.chinn@segment.com> Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com> Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com> Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com> Co-authored-by: david morton <110892780+daveo237@users.noreply.github.com> Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com> Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com> * catalog update --------- Co-authored-by: rchinn-segment <ryan.chinn@segment.com> Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com> Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com> Co-authored-by: deepdel <45295303+deepdel@users.noreply.github.com> Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: Spencer Attick <23665784+spencerattick@users.noreply.github.com> Co-authored-by: Niall Brennan <niallbrennan87@gmail.com> Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com> Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com> Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com> Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM> Co-authored-by: Carl Lee <104832011+carlmlee@users.noreply.github.com> Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com> Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com> Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com> Co-authored-by: david morton <110892780+daveo237@users.noreply.github.com> Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge timing
Related issues (optional)