Skip to content

Note to add destinations in Engage #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2023
Merged

Note to add destinations in Engage #4661

merged 2 commits into from
May 8, 2023

Conversation

estgc
Copy link
Contributor

@estgc estgc commented Apr 27, 2023

Many clients are confused when adding this Engage destination as they add them through connections instead of inside the Engage space

Proposed changes

Added a note that this needs to be added within the Engage space settings.

Merge timing

Related issues (optional)

Many clients are confused when adding this Engage destination as they add them through connections instead of inside the Engage space
@estgc estgc added the KCS label Apr 27, 2023
@estgc estgc marked this pull request as ready for review April 28, 2023 00:00
@estgc estgc requested a review from a team as a code owner April 28, 2023 00:00
@estgc estgc requested review from markzegarelli and removed request for a team April 28, 2023 00:00
@markzegarelli markzegarelli merged commit f057cbf into develop May 8, 2023
@markzegarelli markzegarelli deleted the estgc-patch-4 branch May 8, 2023 22:41
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request May 9, 2023
* Add info about properties with the "\" character

* Fix typo

* Add Selective Sync

* Update intro and other edits

* Update debugger.md

Added information that the source should not be disabled also.

Original sentence:
This automatically generated source cannot be deleted even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

Added "and should not be disabled" and modified to:
This automatically generated source cannot be deleted and should not be disabled even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

* Fixed Typo

* [netlify-build]

* update name per partner request

* article edits and casing fixes

* Update src/connections/destinations/catalog/userpilot/index.md

* Update index.md

* Update index.md

* Engineer feedback

* Update src/unify/profiles-sync/index.md

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* Remove grammatical error

* Note to add destinations in Engage (#4661)

* Note to add destinations in Engage

Many clients are confused when adding this Engage destination as they add them through connections instead of inside the Engage space

* Update src/connections/destinations/catalog/personas-facebook-custom-audiences/index.md

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* go GA with @segment/analytics-node (#4675)

* go GA with @segment/analytics-node

* Update src/connections/sources/catalog/libraries/server/node/classic.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Add `List Members` collection to public docs (#4692)

* Add List Members Collection to docs - Update index.md

Added the list members collection to the docs, as success eng is able to manually sync this collection for customer.

Relevant JIRA: https://segment.atlassian.net/browse/SRC-364

* Update index.md

edit list members collection

* Revert "go GA with @segment/analytics-node (#4675)" (#4695)

This reverts commit e7e06de.

* Update Object API FAQ to point to Reverse ETL

* Fix Stream Page Typos

* Update email and sms subscription field.md

These fields need double underscores instead of just 1.

* Fix Broken Link #4691

* Usermaven Deploy branch (#4656)

* feat: usermaven destination docs

* feat: usermaven destination docs

* feat: updated usermaven doc

* Add id and metadata

* Apply suggestions from code review

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: seeratawan01 <seeratsdsking@gmail.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* add `>` to render code snippet correctly

* catalog update (#4702)

* Add info about Event Names (#4688)

* Add info about Event Names 

Add clarification on the dropdown selector given to customers when they search for event names in the Transformations page.

* Update src/protocols/transform/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>
Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: tanjinhong72 <82503411+tanjinhong72@users.noreply.github.com>
Co-authored-by: Jazma Foskin <82051355+jfoskin@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com>
Co-authored-by: Seth Silesky <5115498+silesky@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com>
Co-authored-by: pwseg <paul.wooley@segment.com>
Co-authored-by: seeratawan01 <seeratsdsking@gmail.com>
Co-authored-by: prigiattiperrut <47340158+prigiattiperrut@users.noreply.github.com>
markzegarelli pushed a commit that referenced this pull request May 11, 2023
* Tracking Plan implememneted

* Update faq.md

* Add info about properties with the "\" character

* Fix typo

* Add navattic source doc

* Open Navattic site in new tab

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Specify support team as Navattic

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Delete quote block that was supposed to be deleted

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Describe steps to Add source

Instead of using hyperlink

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Use markdown table

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

* Remove HTML table

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Use markdown table for property name/description

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Remove HTML table for properties

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply syntax suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Update faq.md

* Mixpanel Cohorts update

* Add Selective Sync

* Update intro and other edits

* Update debugger.md

Added information that the source should not be disabled also.

Original sentence:
This automatically generated source cannot be deleted even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

Added "and should not be disabled" and modified to:
This automatically generated source cannot be deleted and should not be disabled even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

* Fixed Typo

* [netlify-build]

* update name per partner request

* article edits and casing fixes

* Update src/connections/destinations/catalog/userpilot/index.md

* Update index.md

* Update index.md

* edits

* Engineer feedback

* Update src/unify/profiles-sync/index.md

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* Remove grammatical error

* Note to add destinations in Engage (#4661)

* Note to add destinations in Engage

Many clients are confused when adding this Engage destination as they add them through connections instead of inside the Engage space

* Update src/connections/destinations/catalog/personas-facebook-custom-audiences/index.md

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* go GA with @segment/analytics-node (#4675)

* go GA with @segment/analytics-node

* Update src/connections/sources/catalog/libraries/server/node/classic.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Add `List Members` collection to public docs (#4692)

* Add List Members Collection to docs - Update index.md

Added the list members collection to the docs, as success eng is able to manually sync this collection for customer.

Relevant JIRA: https://segment.atlassian.net/browse/SRC-364

* Update index.md

edit list members collection

* Revert "go GA with @segment/analytics-node (#4675)" (#4695)

This reverts commit e7e06de.

* Update Object API FAQ to point to Reverse ETL

* Fix Stream Page Typos

* Update email and sms subscription field.md

These fields need double underscores instead of just 1.

* Fix Broken Link #4691

* Update src/connections/sources/catalog/cloud-apps/mixpanel-cohorts/index.md

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* Apply suggestions from code review

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* Usermaven Deploy branch (#4656)

* feat: usermaven destination docs

* feat: usermaven destination docs

* feat: updated usermaven doc

* Add id and metadata

* Apply suggestions from code review

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: seeratawan01 <seeratsdsking@gmail.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* add `>` to render code snippet correctly

* Update src/protocols/faq.md

* Update src/connections/sources/catalog/cloud-apps/navattic/index.md

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* catalog update (#4702)

* Add info about Event Names (#4688)

* Add info about Event Names 

Add clarification on the dropdown selector given to customers when they search for event names in the Transformations page.

* Update src/protocols/transform/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Updating Mixpanel Public Doc Link 

link for Identity Merge Feature was broken. Updated with new link confirmed by Mixpanel team

* Add Link Shortening content

* Adding  CleverTap to the list of supported plugin

* PM feedback

* apply suggestions from code review

* Add fetch-retry dependency

* moved to be in alphabetical order

* Change code to stop reference array being cleared

Changing code to avoid bad behavior

* feat: add "Spec: Alias" to navbar

* small edit

* fix: remove trailing whitespaces

* catalog update

* Updated AWS S3 language

* Update index.md (#4218)

* GA4 handling null/object/array types event parameters (#4075)

Update from engineers on how GA4 & Segment handles null/object/array types event parameters
in Slack : #integrations-actions-collab (https://twilio.slack.com/archives/C01RWN725QW/p1674000598496369)

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

---------

Co-authored-by: Jazma Foskin <82051355+jfoskin@users.noreply.github.com>
Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>
Co-authored-by: Albert Yu <albert.yu@navattic.com>
Co-authored-by: Albert Yu <albert-yu@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: tanjinhong72 <82503411+tanjinhong72@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com>
Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM>
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com>
Co-authored-by: Seth Silesky <5115498+silesky@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com>
Co-authored-by: pwseg <paul.wooley@segment.com>
Co-authored-by: seeratawan01 <seeratsdsking@gmail.com>
Co-authored-by: prigiattiperrut <47340158+prigiattiperrut@users.noreply.github.com>
Co-authored-by: Sena Diaz <sdiaz@twilio.com>
Co-authored-by: Niall Brennan <nbrennan@twilio.com>
Co-authored-by: Gustavo Carvalho <gustavo.hcarvalho@outlook.com>
Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com>
Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com>
markzegarelli pushed a commit that referenced this pull request May 16, 2023
* Tracking Plan implememneted

* Update faq.md

* Add info about properties with the "\" character

* Fix typo

* Add navattic source doc

* minor tweaks from inkit

* Open Navattic site in new tab

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Specify support team as Navattic

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Delete quote block that was supposed to be deleted

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Describe steps to Add source

Instead of using hyperlink

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Use markdown table

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply wording suggestion

* Remove HTML table

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Use markdown table for property name/description

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Remove HTML table for properties

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Apply syntax suggestion

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>

* Update faq.md

* Mixpanel Cohorts update

* Add Selective Sync

* Update intro and other edits

* Update debugger.md

Added information that the source should not be disabled also.

Original sentence:
This automatically generated source cannot be deleted even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

Added "and should not be disabled" and modified to:
This automatically generated source cannot be deleted and should not be disabled even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.

* Fixed Typo

* [netlify-build]

* 1

* update name per partner request

* article edits and casing fixes

* Update src/connections/destinations/catalog/userpilot/index.md

* Update index.md

* Update index.md

* edits

* Engineer feedback

* Update src/unify/profiles-sync/index.md

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* Remove grammatical error

* Note to add destinations in Engage (#4661)

* Note to add destinations in Engage

Many clients are confused when adding this Engage destination as they add them through connections instead of inside the Engage space

* Update src/connections/destinations/catalog/personas-facebook-custom-audiences/index.md

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* go GA with @segment/analytics-node (#4675)

* go GA with @segment/analytics-node

* Update src/connections/sources/catalog/libraries/server/node/classic.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Add `List Members` collection to public docs (#4692)

* Add List Members Collection to docs - Update index.md

Added the list members collection to the docs, as success eng is able to manually sync this collection for customer.

Relevant JIRA: https://segment.atlassian.net/browse/SRC-364

* Update index.md

edit list members collection

* Revert "go GA with @segment/analytics-node (#4675)" (#4695)

This reverts commit e7e06de.

* Update and rename persistence.md to cookie validity update.md

* Update Object API FAQ to point to Reverse ETL

* Fix Stream Page Typos

* Update email and sms subscription field.md

These fields need double underscores instead of just 1.

* Update cookie validity update.md

* Fix Broken Link #4691

* Update src/connections/sources/catalog/cloud-apps/mixpanel-cohorts/index.md

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* Apply suggestions from code review

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* Usermaven Deploy branch (#4656)

* feat: usermaven destination docs

* feat: usermaven destination docs

* feat: updated usermaven doc

* Add id and metadata

* Apply suggestions from code review

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: seeratawan01 <seeratsdsking@gmail.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* add `>` to render code snippet correctly

* Update src/protocols/faq.md

* Update src/connections/sources/catalog/cloud-apps/navattic/index.md

Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>

* catalog update (#4702)

* Add info about Event Names (#4688)

* Add info about Event Names 

Add clarification on the dropdown selector given to customers when they search for event names in the Transformations page.

* Update src/protocols/transform/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Updating Mixpanel Public Doc Link 

link for Identity Merge Feature was broken. Updated with new link confirmed by Mixpanel team

* Add Link Shortening content

* [braze-cohorts] update instructions for multi mapping setup

* Adding  CleverTap to the list of supported plugin

* PM feedback

* apply suggestions from code review

* Add fetch-retry dependency

* moved to be in alphabetical order

* Update cookie validity update.md

* Change code to stop reference array being cleared

Changing code to avoid bad behavior

* Update cookie validity update.md

Commented out "7 days"

* feat: add "Spec: Alias" to navbar

* small edit

* fix: remove trailing whitespaces

* change via to through

* catalog update

* Updated AWS S3 language

* Update index.md (#4218)

* GA4 handling null/object/array types event parameters (#4075)

Update from engineers on how GA4 & Segment handles null/object/array types event parameters
in Slack : #integrations-actions-collab (https://twilio.slack.com/archives/C01RWN725QW/p1674000598496369)

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

* change name to remove IO

* add test message content

* [netlify-build]

* Update SMS campaigns

* Update src/connections/sources/catalog/libraries/website/javascript/cookie validity update.md

* edits

* Add redirect for name update

* Add callout for ROW UI update

* rephrase as per review comment

* fix: typo

* Update source name

* Add note about Marketo's Lead Activity Type IDs field (#4730)

* Add note about Marketo's Lead Activity Type IDs field

* Update src/connections/sources/catalog/cloud-apps/marketo/index.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

---------

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>

* Add note about Talon.One rate limit (#4729)

* Add note that Help Scout OAuth supports one destination per user (#4728)

* Removed outdated info (#4741)

* add new events for braze (#4727)

* add new events for braze

* add consistent punctuation

* Catalog update

* Add PM feedback

---------

Co-authored-by: Jazma Foskin <82051355+jfoskin@users.noreply.github.com>
Co-authored-by: Sarah Rudy <78389005+sarahrudy@users.noreply.github.com>
Co-authored-by: Albert Yu <albert.yu@navattic.com>
Co-authored-by: Thomas Gilbert <thomas.gilbert@segment.com>
Co-authored-by: Albert Yu <albert-yu@users.noreply.github.com>
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Co-authored-by: rchinn-segment <ryan.chinn@segment.com>
Co-authored-by: tanjinhong72 <82503411+tanjinhong72@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM>
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Co-authored-by: Esteban Gonzalez Corti <esteban.gonzalezcorti@segment.com>
Co-authored-by: Seth Silesky <5115498+silesky@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: Charity Holt <38872070+charholt@users.noreply.github.com>
Co-authored-by: vanand17 <96406241+vanand17@users.noreply.github.com>
Co-authored-by: pwseg <paul.wooley@segment.com>
Co-authored-by: seeratawan01 <seeratsdsking@gmail.com>
Co-authored-by: prigiattiperrut <47340158+prigiattiperrut@users.noreply.github.com>
Co-authored-by: Sena Diaz <sdiaz@twilio.com>
Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com>
Co-authored-by: Niall Brennan <nbrennan@twilio.com>
Co-authored-by: Gustavo Carvalho <gustavo.hcarvalho@outlook.com>
Co-authored-by: bobbyatsegment <93934274+bobbyatsegment@users.noreply.github.com>
Co-authored-by: Liz Kane <68755692+lizkane222@users.noreply.github.com>
Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com>
Co-authored-by: Sayan Das <109198085+sayan-das-in@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants