Release 23.19.1 #4705
Merged
Release 23.19.1 #4705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added information that the source should not be disabled also. Original sentence: This automatically generated source cannot be deleted even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed. Added "and should not be disabled" and modified to: This automatically generated source cannot be deleted and should not be disabled even when the destination is removed, in order for Segment to function as designed. The source will be reused by Segment as needed.
Added information that the Engage generated source should not be disabled
update name per partner request
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
* Note to add destinations in Engage Many clients are confused when adding this Engage destination as they add them through connections instead of inside the Engage space * Update src/connections/destinations/catalog/personas-facebook-custom-audiences/index.md --------- Co-authored-by: markzegarelli <mark.zegarelli@segment.com>
* go GA with @segment/analytics-node * Update src/connections/sources/catalog/libraries/server/node/classic.md Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> --------- Co-authored-by: markzegarelli <mark.zegarelli@segment.com> Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Remove grammatical error
* Add List Members Collection to docs - Update index.md Added the list members collection to the docs, as success eng is able to manually sync this collection for customer. Relevant JIRA: https://segment.atlassian.net/browse/SRC-364 * Update index.md edit list members collection
These fields need double underscores instead of just 1.
Update email and sms subscription field.md
Add Selective Sync content
Fix Build a Stream Typos
* feat: usermaven destination docs * feat: usermaven destination docs * feat: updated usermaven doc * Add id and metadata * Apply suggestions from code review Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> --------- Co-authored-by: seeratawan01 <seeratsdsking@gmail.com> Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Add info about properties with the "\" character
Fix Broken Analytics.js Link
* Add info about Event Names Add clarification on the dropdown selector given to customers when they search for event names in the Transformations page. * Update src/protocols/transform/index.md Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> --------- Co-authored-by: markzegarelli <mark.zegarelli@segment.com> Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
markzegarelli
requested review from
forstisabella,
rchinn1,
pwseg and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.