-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RefreshOptions: Add truthiness check when sorting optgroups with lockOptgroupOrder #1163
Conversation
When using 'lockOptgroupOrder' - if b is not defined it throws an error breaking the component. This change fixes this issue by checking whether it has something to compare first before trying to get access to the object property.
Oops, you changed |
Same update applied to the dist version.
@joallard thanks for the heads up! I only updated dist to rectify my current issue not thinking about the actual build... Updated patch also 👍 |
Sorry to make you go back and forth on this, but there's no way to do this simply in the Github interface: can you rebase and remove your first commit, leaving just the changes to Otherwise I'm ready to merge as-is, it's trivial enough to be comprehendable. |
I attempted to use selectize.js with a `create: function(input, callback) {}` pattern, as suggested by the docs. This wouldn't work, as the function never returns anything.. After some light debugging, I realized that the `callback` function wasn't being used or defined. I tried setting up the function given in the example, and it worked. I checked some of the examples with this definition, and they all followed the given format.
Added information about default values and asynchronous function
Wasted a lot of time because triggerDropdown was not documented.
Use correct jQuery API to get option value Fixes selectize#1016
Replacing jQuery for $
Closes selectize#785 [skip-ci] - Some typo fixes - Fixes selectize#779, selectize#745, selectize#464 and perhaps some others (Markdown doesn't work inside tables :-( )
… to the selectize input/select selectize#658
- Correct tests - Use hyphen instead of underscore in new node id
- tweak handling under iOS - improve blur handling and add option - improve pullrequest based on helpful feedback - change CHANGELOG
Even though we still need to get a team on the ground [skip ci]
[skip ci]
[skip ci]
[skip ci]
Replaced reference to window.jQuery in removeHighlight plugin
Sometimes element passed as second argument to onBlur handler doesn't have focus method, i.e. inline svg element in IE
When using 'lockOptgroupOrder' - if b is not defined it throws an error breaking the component. This change fixes this issue by checking whether it has something to compare first before trying to get access to the object property.
Same update applied to the dist version.
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
When using 'lockOptgroupOrder' - if b is not defined it throws an error breaking the component. This change fixes this issue by checking whether it has something to compare first before trying to get access to the object property.