[🐛 Bug]: Java. CDP failed to deserialize params for TargetFilter

[vlad8x8]

What happened?

Chrome Devtools failed to deserialize params for TargetFilter if it's not Optional.empty()

I tried:
new FilterEntry(empty(), Optional.of("page"))
new FilterEntry(Optional.of(true), Optional.of("page")
new FilterEntry(Optional.of(false), Optional.of("page")

How can we reproduce the issue?

package org.example;

import org.openqa.selenium.chrome.ChromeDriver;
import org.openqa.selenium.devtools.v119.target.Target;
import org.openqa.selenium.devtools.v119.target.model.FilterEntry;
import org.openqa.selenium.devtools.v119.target.model.TargetFilter;

import java.util.ArrayList;
import java.util.List;
import java.util.Optional;

public class Main {
    public static void main(String[] args) {
        List<FilterEntry> list = new ArrayList<>();
        list.add(new FilterEntry(Optional.of(true), Optional.of("page")));
        TargetFilter filter = new TargetFilter(list);
        new ChromeDriver().getDevTools().send(Target.getTargets(Optional.of(filter)));
    }
}

Relevant log output

Exception in thread "main" org.openqa.selenium.devtools.DevToolsException: {"id":1,"error":{"code":-32602,"message":"Invalid parameters","data":"Failed to deserialize params.filter - CBOR: array start expected at position 22"}}
Build info: version: '4.16.0-SNAPSHOT', revision: 'b9ef666'
System info: os.name: 'Windows 10', os.arch: 'amd64', os.version: '10.0', java.version: '11.0.21'
Driver info: driver.version: unknown
	at org.openqa.selenium.devtools.Connection.sendAndWait(Connection.java:193)
	at org.openqa.selenium.devtools.DevTools.send(DevTools.java:89)
	at org.example.Main.main(Main.java:17)
Caused by: org.openqa.selenium.WebDriverException: {"id":1,"error":{"code":-32602,"message":"Invalid parameters","data":"Failed to deserialize params.filter - CBOR: array start expected at position 22"}}
Build info: version: '4.16.0-SNAPSHOT', revision: 'b9ef666'
System info: os.name: 'Windows 10', os.arch: 'amd64', os.version: '10.0', java.version: '11.0.21'
Driver info: driver.version: unknown
	at org.openqa.selenium.devtools.Connection.handle(Connection.java:272)
	at org.openqa.selenium.devtools.Connection$Listener.lambda$onText$0(Connection.java:236)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

Operating System

Windows 10

Selenium version

Java 4.16 Night build

What are the browser(s) and version(s) where you see this issue?

Chrome 119

What are the browser driver(s) and version(s) where you see this issue?

se:cdpVersion -> 119.0.6045.160

Are you using Selenium Grid?

no

[github-actions]

@vlad8x8, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[vlad8x8]

@joerg1985 could you please take a look if it's related your fixes for array parameters?

[joerg1985]

@vlad8x8 i checked it, this time i am not guilty. The toJson methods are missing for some classes ending in empty json generated. The CdpClientGenerator needs to be fixed to generate these methods for these classes.

[github-actions]

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

[titusfortner]

Actually, let's just track this in #13189

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.