Skip to content

38c216a

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 20 Nov 18:14

fix(ws): Log and apply a rate change only where the rate changes

A capped CRF display's ceiling follows its largest frames and carries a
fraction of a kbps. A sounding that landed on it compared the unrounded
landing with the rounded current rate, so every landing at the ceiling
logged "video bitrate 124185 -> 124185 kbps (the path carried the
padding past the configured rate)" at info and retargeted the encoder
to the rate it already had: on a fast path, the line repeats without
end. WebRTC's steer did the same where a capped display's probe held
the target at its current rate.

  • Both compare in whole kbps, so such a landing logs and applies
    nothing.
  • A sounding's change logs as the steer's own do: a cut at info, a
    rise at debug.

a_capped_display_landing_on_its_own_ceiling_retargets_nothing fails
before the change (a landing held at 124185.4 applies 124185) and
passes after it. The ws:: and webrtc:: tests pass (257), and so does
pre-commit.