Skip to content

3c405cb

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 18 Nov 06:12

fix(ws): Back off at once from a link that narrows while a cut drains

After a cut the steer holds its target while the queue the cut found drains, and cuts nothing
more until the drain and SETTLE_S are over, since the draining queue reads as one meanwhile. A
link that slowed inside that wait met the old path's target for its rest: over WebSockets a
cut about a second before a link went from 10 to 4 Mbit/s left three ticks reading a standing
queue on 3.8 Mbit/s delivered (from 9.5) with nothing cut, the picture falling behind until the
hold ran out.

A drain delivers what the path did. A queued tick delivering under NARROWED (60%) of the
capacity the cut measured is a slower link, and the WebSockets link ends the hold on it, so the
tick backs off to what the path delivers now (CongestionSteer::narrowed, end_hold). WebRTC keeps
the hold as it was: on its congestion step the same rule made no gain.

On the WebSockets congestion step (tests/perf/congestion_step.spec.ts, 10 -> 4 Mbit/s held 8 s,
a 30 Mbit/s target, the heavy scene), 6 interleaved pairs against main:

                                     main        this

time until the picture is live 2.9-4.7 s 2.2-2.7 s
median 3.95 s 2.25 s
worst age while narrowed, median 1.22 s 1.25 s

The worst age is what the old rate wrote before the first narrowed tick, which no cut takes
back.

For #620.