Skip to content

e6e107c

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 20 Nov 13:14

fix(scanner): Compile the image's tests without running them

The OSS Scanner's pull request check builds .oss-scanner/Dockerfile on a
GitHub-hosted runner, which has 45 minutes for the whole build and
about 40 for the Dockerfile, and ran out of them: running the tests
took 580 s, and the image's layers were still being written when the
time ran out.

  • The tests are compiled and not run; the scan runs them, and the end
    of the file lists how, the workspace's with --no-fail-fast.
  • The image's Cargo configuration (.oss-scanner/cargo-config.toml,
    installed in CARGO_HOME) keeps line tables only for crates.io and git
    dependencies, and full debug info for the workspace, the vendored rtc
    crates and pixelflux's bindings.
  • threat_model.md names the six tests that need a network interface
    besides loopback; the three AGENTS.md describe the image as compiling
    the tests.

With the scanner's own tools/check (oss-scanner a7e4e111) on
ubuntu-latest:

  • tests compiled, not run: 2092 s of 2700; a 26.1 GB test layer, written
    in 747 s and unpacked in 245 s;
  • and line tables for dependencies (this change): 1788 s; 19.9 GB, 569
    and 114 s;
  • and no incremental caches as well: 1437 s; 12.2 GB. Not taken, since
    the scan rebuilds after each patch it tries.
    In each image, offline, the unit tier passes 55 of 55, the pixelflux,
    pcmflux and vendored crates' tests pass, and the workspace's pass but
    for those six.