-
Notifications
You must be signed in to change notification settings - Fork 90
feat: comment on issues and merge requests resolved by current release #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: comment on issues and merge requests resolved by current release #332
Conversation
f58ed63 to
79dd0d7
Compare
|
OK, this is ready for review. See https://gitlab.com/fgreinacher/semantic-release-comments/-/merge_requests/4 and its linked issues for a sample run from the current version of the this PR. /cc @pvdlg @tmeijn @nfriend @joshdcomp as you have been active in the original issue. |
1a56987 to
a443848
Compare
|
@fgreinacher Awesome! Two points of feedback I have:
Thanks again! |
13ee743 to
3ee2273
Compare
3ee2273 to
63383ad
Compare
Good catch, thanks! I fixed this and also use the full release URL now. |
|
@semantic-release I am not sure who is currently maintaining this repository. Could you help me find the right reviewer? |
|
@travi Are you currently active here and would review this? 🙏 |
185045c to
3aa3a18
Compare
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@travi Eek, seems the squash commit did not contain my breaking change trailer, making this 7.1.0 instead of 8.0.0 :/ Should I revert this for 7.1.1 and recommit with the correct message? |
|
Yeah, that's the route that I would recommend. I've approved your draft PR for the revert. I do wish that GitHub would do better with copying commit body details into the suggested squash message in situations like this. |
BREAKING CHANGE: By default all related issues and MRs are commented. Set the
successCommentoption tofalseto disable that.Fixes #40
🛠 with ❤ at Siemens