-
Notifications
You must be signed in to change notification settings - Fork 90
feat: convert package to ESM #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6277fa0 to
caa9edf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
what would you think about releasing this as a beta before promoting to stable? we just released a beta of the npm plugin so we could try it in some real releases first since we havent fully proven out that core is ready to load esm plugins quite yet
in our attempt to release a beta of core that included the beta of the npm plugin, we confirmed that we needed another iteration to handle loading esm plugins properly. until we promote that fix to stable, i think i'd advise against releasing this as stable quite yet |
Good idea, I rebased this against a |
Yep that'll do it |
|
🎉 This PR is included in version 9.6.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 great to see this make it's way out. Thanks for moving this forward, @fgreinacher! One thing that I would highlight is that the esm transition should be considered breaking, but looks like it wasn't released that way in this case. Could you re-release to call out that breaking change? That way when promoted to stable the release will cover it then too. Also, when we do promote to stable, I recommend a normal merge so the releases from the pre-release branch are preserved. |
|
Thanks for your thoughts @travi! Yea, I noticed that I forgot the breaking change trailer. What’s the best way to perform a re-release? Delete the tag and force-push? Regarding the merge strategy: Currently this repo is configured to enforce squash merge. Could you change that setting? |
yeah, all options are a bit ugly, but i that approach should work fine
i updated to enable squash or normal merges, so you should be good to go once you're ready to promote to stable. just a reminder that you'll likely want to wait until one of the options mentioned here (promoting the current core beta to stable, or backporting the handling of esm plugins to core) make their way to the stable version of core. |
BREAKING CHANGE: This package is now ESM-only and cannot be used by CJS packages. BREAKING CHANGE: The minimum supported Node version has been changed to 18.0.0.
BREAKING CHANGE: This package is now ESM-only and cannot be used by CJS packages. BREAKING CHANGE: The minimum supported Node version has been changed to 18.0.0.
Contributes to semantic-release/semantic-release#2133