fix(generic-packages): set correct URL for external provider and default storage #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
changed the title
|
Looking good, Thanks for the quick diagnosis and response @JonasSchubert |
fgreinacher
approved these changes
Feb 15, 2023
|
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL is dependent on the configuration of asset storage which might defer in any Gitlab instance. The tested instance I used in #491 uses an external provider, but private hosted instances will use a Gitlab mount.
This PR checks whether an URL is of valid scheme (http, https or ftp) and uses the URL if already valid. If it is a relative path as mentioned in #497 it will use
urlJointo create a valid URL.Closes #497