-
Notifications
You must be signed in to change notification settings - Fork 22
Remove inverses. Fixes #506. #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@marksem @uscholdm @dylan-sa On further thought, |
This is a vaid distinction, but let's treat that as a separate issue "Do we add a gist:descibes property". If there was a demonstrated need for both, maybe. But I'd need some convincing. Is about seems fine for most purposes. |
It would be super nice for this table to be alpha sorted so one can look things up. |
Normally I like to keep issues atomic, as you suggest, but this one is different. If they are not true inverses, and we remove one of them, we are removing a concept that is no longer expressible in gist. The short-term solution is to keep both and remove the inverse axiom, and consider later whether we can drop one of them. |
I do not that is what is happening. We are removing a property whose only meaning ever was to be the inverse of isAbout. It was poorly named. |
OK, valid point. I withdraw my proposal and have added new issue #814. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the serializer has not run on these commits. @dylan-sa You should check your setup. Did you run tools/setup.cmd
after you pulled the latest from develop?
You're right--this wasn't set up correctly. Fixed with latest commit. |
Good idea--I have tweaked the ordering. 👍 |
Agree that this is a better name for the inverse--worth considering in a separate issue. |
I am curious about the decision to keep gist:governs and remove gist:isGovernedBy. I looked at the spreadsheet posted by Dylan on 3/28/2023 and I'm unclear on what the column names really mean (the Group Consensus column contradicts the Recommend Keeping column). But my main comment is that the implemented choice seems to go against our general rule of thumb of lower cardinality. I would think gist:isGovernedBy is goes from the leafs and points to the root of a tree (hierarchy). But you've chosen the other direction. This seems to be the higher cardinality relation. And it isn't obvious to me that there is a specific semantic or use case benefit to choosing gist:governs instead. |
Sorry for confusion on the spreadsheet--Group Consensus indicates what the working group settled on keeping, whereas Recommend Keeping is from an earlier version of the spreadsheet. The table at the top of the PR is a better source for the working group proposal. |
@Jamie-SA We brought other considerations to bear on the decision. In this case, due to the verbosity of isGovernedBy, we opted for governs. It's more a matter of balancing criteria than having hard-and-fast rules. In this particular case I could personally go either way. |
@rjyounes @Jamie-SA @hmoore-sa - After some more adjustments, this one is ready for review. Would appreciate everyone's thoughts when you get a chance to look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work - it looks like you caught everything.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but with comments.
### Major Updates | ||
|
||
- Removed all inverse properties. Issue [#506](https://github.com/semanticarts/gist/issues/506). | ||
- For each pair of inverses, the property deemed clearest, simplest, and/or most useful was retained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this should list the removed properties? Yes, there is a link to the issue, but if someone just scans the release notes it might be nice for them to be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this should list the removed properties? Yes, there is a link to the issue, but if someone just scans the release notes it might be nice for them to be here.
Yes, I strongly agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
gist:hasDirectSubCategory | ||
a owl:ObjectProperty ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the removal of hasDirectSubCategory
in the table in the issue or PR discussions. It's removal should be documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point. I'll add that to the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just follow Jamie's suggestion of adding the list to the release note. Then it's good to go.
I can get behind Jamie's suggestion to go with Michael does make a fair point that it's similar in meaning to |
I think we should get consensus before making yet another flip/flop. M. |
I agree. I’d like to reconvene our small group. It’s important to get these right so we don’t regret it later. Is that OK with everyone?
From: Michael Uschold ***@***.***>
Date: Thursday, April 27, 2023 at 9:40 PM
To: semanticarts/gist ***@***.***>
Cc: Rebecca Younes ***@***.***>, Mention ***@***.***>
Subject: Re: [semanticarts/gist] Remove inverses. Fixes #506. (PR #813)
I can get behind Jamie's suggestion to go with isGeographicallyContainedIn.
Michael does make a fair point that it's similar in meaning to isPartOf, which we are dropping; but relating regions using the smaller-to-larger direction has proved useful for regions hierarchies.
I think we should get consensus before making yet another flip/flop.
M.
—
Reply to this email directly, view it on GitHub<#813 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAM5PZGRSHKWGGJVAQL5SQDXDMNXVANCNFSM6AAAAAAWNVYA5Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Decision after 5/1 working group meeting is to go w/ |
Hi Dylan, Took a look, mostly focusing on the isGeographicallyContainedIn changes, and looks like you got everything as far as I can see. Continuing to be signed off! |
Serializer test 2 serializer test 3 Serializer test 4 serializer test 5 Serializer test 6 Serializer test 7
4ca767f
to
def36eb
Compare
Fixes #506.
This PR includes changes related to the removal of inverse properties from gist:
becomes
isGovernedBy
.)Breakdown (updated after 5/1 working group meeting):
hasDirectPart
isDirectPartOf
hasDirectSubTask
isDirectSubTaskOf
hasDirectSuperCategory
hasDirectSubCategory
hasMember
isMemberOf
hasNavigationalParent
hasNavigationalChild
hasPart
isPartOf
hasSubTask
isSubTaskOf
hasSuperCategory
hasSubCategory
isAbout
isDescribedIn
isAffectedBy
affects
isBasedOn
isBasisFor
isGeographicallyContainedIn
containsGeographically
isGovernedBy
governs
isIdentifiedBy
identifies
isRecognizedBy
recognizes
occupiesGeographically
isGeographicallyOccupiedBy
occupiesGeographicallyPermanently
isGeographicallyPermanentlyOccupiedBy
precedes
follows
precedesDirectly
followsDirectly
Shared spreadsheet with final summary and proposal history. (SA folks can access.)