Skip to content

Remove inverses. Fixes #506. #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 3, 2023
Merged

Remove inverses. Fixes #506. #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eb4354f
Remove inverses and fix class axioms
dylan-sa Mar 30, 2023
9afde15
Changes to sub/supercategory predicates
dylan-sa Mar 30, 2023
db70d55
Fix typo in occupiesGeographically definition
dylan-sa Mar 30, 2023
3d5a5c1
Add rangeIncludes for isMemberOf
dylan-sa Mar 30, 2023
9ffd093
Add release note
dylan-sa Mar 30, 2023
a2cc70d
Serializer test
dylan-sa Apr 4, 2023
f52223d
Change hasFirstMember to isFirstMemberOf
dylan-sa Apr 4, 2023
74a5128
adding updated proposal
dylan-sa Apr 6, 2023
404cd63
Update release note
dylan-sa Apr 7, 2023
0e56d30
Remove identifies predicate
dylan-sa Apr 7, 2023
13e4121
Add property breakdown to release note
dylan-sa Apr 27, 2023
a1530c5
Add back isGeographicallyContainedIn
dylan-sa May 1, 2023
def36eb
Fix release note
dylan-sa May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions docs/release_notes/pr813.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
### Major Updates

- Removed all inverse properties. Issue [#506](https://github.com/semanticarts/gist/issues/506)

- For each pair of inverses, the property deemed clearest, simplest, and/or most useful was retained.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this should list the removed properties? Yes, there is a link to the issue, but if someone just scans the release notes it might be nice for them to be here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this should list the removed properties? Yes, there is a link to the issue, but if someone just scans the release notes it might be nice for them to be here.

Yes, I strongly agree

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

- Relevant axioms changed to include only properties that were kept in gist.
- Breakdown:

| Properties retained in gist | Inverse properties removed from gist|
| ----------- | ----------- |
`hasDirectPart` | `isDirectPartOf`
`hasDirectSubTask` | `isDirectSubTaskOf`
`hasDirectSuperCategory` | `hasDirectSubCategory`
`hasMember` | `isMemberOf`
`hasNavigationalParent` | `hasNavigationalChild`
`hasPart` | `isPartOf`
`hasSubTask` | `isSubTaskOf`
`hasSuperCategory` | `hasSubCategory`
`isAbout` | `isDescribedIn`
`isAffectedBy` | `affects`
`isBasedOn` | `isBasisFor`
`isGeographicallyContainedIn` | `containsGeographically`
`isGovernedBy` | `governs`
`isIdentifiedBy` | `identifies`
`isRecognizedBy` | `recognizes`
`occupiesGeographically` | `isGeographicallyOccupiedBy`
`occupiesGeographicallyPermanently` | `isGeographicallyPermanentlyOccupiedBy`
`precedes` | `follows`
`precedesDirectly` | `followsDirectly`
Loading