-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement Hebrew translation #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JohnTitor Could you maybe check this? |
This comment was marked as outdated.
This comment was marked as outdated.
YanivD
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a native Hebrew speaker - LGTM
@JohnTitor it's Ready to merge |
🤔 |
YanivD
approved these changes
Dec 13, 2023
JohnTitor
approved these changes
Dec 14, 2023
Sorry for the delay and thank you all for contributing and reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr corrects the masculine/feminine language in Hebrew according to the guidelines of the official Hebrew language academy, and many other translation fixes.
https://hebrew-academy.org.il/2010/10/04/%D7%90%D7%99%D7%9A-%D7%A4%D7%95%D7%A0%D7%99%D7%9D-%D7%9C%D7%A7%D7%91%D7%95%D7%A6%D7%94-%D7%A9%D7%A8%D7%95%D7%91%D7%94-%D7%A0%D7%A9%D7%99%D7%9D/#:~:text=%D7%A6%D7%95%D7%A8%D7%AA%20%D7%94%D7%96%D7%9B%D7%A8%20%D7%91%D7%A2%D7%91%D7%A8%D7%99%D7%AA%20%D7%9E%D7%A9%D7%9E%D7%A9%D7%AA%20%D7%9C%D7%90%20%D7%A8%D7%A7%20%D7%9C%D7%96%D7%9B%D7%A8.%20%D7%94%D7%99%D7%90%20%D7%92%D7%9D%20%D7%94%D7%A6%D7%95%D7%A8%D7%94%20%D7%A9%D7%90%D7%A0%D7%97%D7%A0%D7%95%20%D7%A0%D7%95%D7%A7%D7%98%D7%99%D7%9D%20%D7%9B%D7%A9%D7%90%D7%99%D7%9F%20%D7%9C%D7%A0%D7%95%20%D7%A6%D7%95%D7%A8%D7%9A%20%D7%9C%D7%94%D7%91%D7%97%D7%99%D7%9F%20%D7%91%D7%9E%D7%99%D7%9F%20%E2%80%93%20%D7%9B%D7%9C%D7%95%D7%9E%D7%A8%20%D7%94%D7%99%D7%90%20%D7%92%D7%9D%20%D7%94%D7%A6%D7%95%D7%A8%D7%94%20%D7%94%D7%A1%D7%AA%D7%9E%D7%99%D7%AA%2C%20%D7%94%D7%9C%D7%90%20%D7%9E%D7%A1%D7%95%D7%9E%D7%A0%D7%AA
https://hebrew-academy.org.il/2021/03/15/%D7%A2%D7%9C-%D7%9B%D7%AA%D7%99%D7%91%D7%94-%D7%A9%D7%95%D7%95%D7%99%D7%95%D7%A0%D7%99%D7%AA/#:~:text=%D7%94%D7%9B%D7%A0%D7%A1%D7%AA%20%D7%A0%D7%A7%D7%95%D7%93%D7%95%D7%AA%20%D7%90%D7%95%20%D7%9C%D7%95%D7%9B%D7%A1%D7%A0%D7%99%D7%9D%20%D7%91%D7%AA%D7%95%D7%9A%20%D7%94%D7%9E%D7%99%D7%9C%D7%94%20%D7%90%D7%99%D7%A0%D7%94%20%D7%9C%D7%A4%D7%99%20%D7%9B%D7%9C%D7%9C%D7%99%20%D7%94%D7%9B%D7%AA%D7%99%D7%91%D7%94%20%D7%A9%D7%9C%20%D7%94%D7%A2%D7%91%D7%A8%D7%99%D7%AA
PR Checklist
spec
dir.npm run lint
.TRANSLATORS.md
.