fix: Fixed a bug where profile bottom position not updating correctly for messages with feedback and replies #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bang9
reviewed
Nov 20, 2024
src/ui/MessageContent/index.tsx
Outdated
| }; | ||
|
|
||
| const totalBottom = useMemo(() => getTotalBottom(), []); | ||
| const totalBottom = getTotalBottom(); |
There was a problem hiding this comment.
이거 한군데서만 쓰이는거면, 그냥 따로 변수선언 없이 바로 넘겨도 좋을 것 같습니다.
chohongm
deleted the
improve/UIKIT-4616-remove-old-container-type-logic
branch
|
아래 UI 스냅샷 테스트 필요:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes UIKIT-4616
Before
After
Test link
Changelogs
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can set up a CLA to allow for the contribution.