Skip to content

fix: Fixed a bug where profile bottom position not updating correctly for messages with feedback and replies #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2024
Merged

fix: Fixed a bug where profile bottom position not updating correctly for messages with feedback and replies #1252

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b3c8c3
fix
chohongm Nov 19, 2024
34330dd
Merge branch 'main' into improve/UIKIT-4616-remove-old-container-type…
chohongm Nov 19, 2024
587943e
fix
chohongm Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/ui/MessageContent/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { ReactElement, ReactNode, useMemo, useRef, useState } from 'react';
import React, { ReactElement, ReactNode, useRef, useState } from 'react';
import format from 'date-fns/format';
import './index.scss';

Expand Down Expand Up @@ -202,19 +202,17 @@ export function MessageContent(props: MessageContentProps): ReactElement {
const showThreadReplies = isNotSpecialMessage && displayThreadReplies;
const showRightContent = isNotSpecialMessage && !isByMe && !isMobile;

const getTotalBottom = (): number => {
const getTotalBottom = (): string => {
let sum = 2;
if (threadRepliesRef.current) {
sum += 4 + threadRepliesRef.current.clientHeight;
}
if (feedbackButtonsRef.current) {
sum += 4 + feedbackButtonsRef.current.clientHeight;
}
return sum;
return sum > 0 ? sum + 'px' : '';
};

const totalBottom = useMemo(() => getTotalBottom(), []);

const onCloseFeedbackForm = () => {
setShowFeedbackModal(false);
};
Expand Down Expand Up @@ -291,7 +289,7 @@ export function MessageContent(props: MessageContentProps): ReactElement {
className: 'sendbird-message-content__left__avatar',
isByMe,
displayThreadReplies,
bottom: totalBottom > 0 ? totalBottom + 'px' : '',
bottom: getTotalBottom(),
})
}
{/* outgoing menu */}
Expand Down