Fix: Mark as read definitely when receiving message #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
approved these changes
Dec 6, 2022
HoonBaek
deleted the
fix/UIKIT-2640/Mark-as-read-when-inserting-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
UIKIT-2686
Description Of Changes
Issue
We have called
markAsReadwhen a newly received message is inserted into the UI message list.But the condition that calculates if the scroll reached the bottom was broken due to the fine pixel difference.
Fix
Add 10px as a buffer when calculating if the scroll reached the bottom
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_