Skip to content

Fix: Mark as read definitely when receiving message #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Fix: Mark as read definitely when receiving message #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7f36e2
Add 10px buffer to calculate if scroll reached to bottom in MessageLi…
HoonBaek Dec 5, 2022
451974e
Add 10px buffer when calculating if scroll reached to bottom in onMes…
HoonBaek Dec 5, 2022
452ae74
Do not memorize message sending status in the MessageStatus comp
HoonBaek Dec 5, 2022
18d487a
Remove unused importing variables
HoonBaek Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/smart-components/Channel/components/MessageList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,27 +84,26 @@ const MessageList: React.FC<MessageListProps> = (props: MessageListProps) => {
});
}

// save the lastest scroll bottom value
// Save the lastest scroll bottom value
if (scrollRef?.current) {
const current = scrollRef?.current;
setScrollBottom(current.scrollHeight - current.scrollTop - current.offsetHeight)
}

// do this later
setTimeout(() => {
// mark as read if scroll is at end
if (!disableMarkAsRead && clientHeight + scrollTop === scrollHeight) {
if (!disableMarkAsRead && isAboutSame(clientHeight + scrollTop, scrollHeight, 10)) {
// Mark as read if scroll is at end
setTimeout(() => {
messagesDispatcher({
type: messageActionTypes.MARK_AS_READ,
payload: { channel: currentGroupChannel },
});
try {
currentGroupChannel?.markAsRead();
currentGroupChannel?.markAsRead?.();
} catch {
//
}
}
}, 500);
}, 500);
}
};

const onClickScrollBot = () => {
Expand Down
3 changes: 2 additions & 1 deletion src/smart-components/Channel/context/hooks/useHandleChannelEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ function useHandleChannelEvents({
let scrollToEnd = false;
try {
const { current } = scrollRef;
scrollToEnd = current.offsetHeight + current.scrollTop >= current.scrollHeight;
scrollToEnd = current.offsetHeight + current.scrollTop >= current.scrollHeight - 10;
// 10 is a buffer
} catch (error) {
//
}
Expand Down
6 changes: 2 additions & 4 deletions src/ui/MessageStatus/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import './index.scss';
import React, { useMemo } from 'react';
import React from 'react';
import format from 'date-fns/format';
import { GroupChannel } from '@sendbird/chat/groupChannel';
import { FileMessage, UserMessage } from '@sendbird/chat/message';
Expand Down Expand Up @@ -29,9 +29,7 @@ export default function MessageStatus({
channel,
}: MessageStatusProps): React.ReactElement {
const { dateLocale } = useLocalization();
const status = useMemo(() => (
getOutgoingMessageState(channel, message)
), [channel, message]);
const status = getOutgoingMessageState(channel, message);
const hideMessageStatusIcon = channel?.isGroupChannel?.() && (
(channel.isSuper || channel.isPublic || channel.isBroadcast)
&& !(status === OutgoingMessageStates.PENDING || status === OutgoingMessageStates.FAILED)
Expand Down