Feature/UI kit 3043/integrate voice message #395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
reviewed
Feb 13, 2023
| mediaRecorder.ondataavailable = (e) => {// when recording stops | ||
| // Generate audio file | ||
| const audioFile = new File([e.data], 'I am file name', { | ||
| const audioFile = new File([e.data], 'Voice message', { |
There was a problem hiding this comment.
Voice message need extension, no?
sravan-s
reviewed
Feb 13, 2023
Comment on lines
+275
to
+279
| isVoiceMessageEnabled: PropTypes.bool, | ||
| voiceRecord: PropTypes.shape({ | ||
| maxRecordingTime: PropTypes.number, | ||
| minRecordingTime: PropTypes.number, | ||
| }), |
There was a problem hiding this comment.
discuss: isnt it better for this prop to be in Channel?
sravan-s
reviewed
Feb 13, 2023
Comment on lines
+3
to
+5
| .sendbird-voice-message-input-wrapper .sendbird-voice-message-input__indicator { | ||
| height: 40px; | ||
| } |
There was a problem hiding this comment.
Isnt .sendbird-voice-message-input__indicator enough?
sravan-s
reviewed
Feb 13, 2023
| import MessageItemReactionMenu from '../../../../ui/MessageItemReactionMenu'; | ||
| import Label, { LabelTypography, LabelColors } from '../../../../ui/Label'; | ||
| import { getClassName, getSenderName, getUIKitMessageType, getUIKitMessageTypes, isOGMessage, isTextMessage, isThumbnailMessage } from '../../../../utils'; | ||
| import { getClassName, getSenderName, getUIKitMessageType, getUIKitMessageTypes, isOGMessage, isTextMessage, isThumbnailMessage, isVoiceMessage } from '../../../../utils'; |
There was a problem hiding this comment.
split into newline pls, sorry, I should have added lint ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
UIKIT-3043
Description Of Changes
Add a brief description of the changes that you have involved in this PR
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_