-
Notifications
You must be signed in to change notification settings - Fork 144
Fix/UI kit 3053/modify issues on voice message #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HoonBaek
merged 91 commits into
develop/Voice-message
from
fix/UIKIT-3053/Modify-issues-on-voice-message
Feb 22, 2023
Merged
Fix/UI kit 3053/modify issues on voice message #405
HoonBaek
merged 91 commits into
develop/Voice-message
from
fix/UIKIT-3053/Modify-issues-on-voice-message
Feb 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add string set * CHANNEL_SETTING__OPERATORS__ADD_BUTTON: 'Add' * CHANNEL_SETTING__MODERATION__EMPTY_BAN: 'No banned members yet' * CHANNEL_SETTING__MODERATION__ALL_BAN: 'All banned members' * Apply string set * on the BannedUserList component * `No banned members yet` * `All banned members` * `Unban` on the context menu of the banned user list * on the BannedUsersModal component * `Unban` on the context menu of the banned user list * on the AddOperatorsModal component * `Add` for the submit button * on the InviteUsersModal component * `Invite` for the submit button * on the MutedMembersModal component * `Unmute` on the context menu of the muted user list * Remove string set * CHANNEL_SETTING__UNMUTE: 'Unmute' * Replace the string set to CHANNEL_SETTING__MODERATION__UNMUTE on the MutedMemberList component * Modify CSS * To improve the word break with StringSet customization on the submit button
* Use the same word-splitting logic on the TextMessage and OGMessage * TextMessage will also allow opening the URL links * Use the same word wrapping style on the TextMessage and OGMessage
* Issue: A customer said the `userIdsFilter` of ChannelListQuery doesn't work when receiving messages There's been an internal channel filtering logic with custom channelListQuery, but it's broken because we've used the outdated interface of Chat SDK. * Fix: We migrated the outdated interface `_searchFilter` and `_userIdsFilter` to new things `searchFilter` and `userIdsFilter`
This was referenced Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
src/smart-components/Channel/components/MessageInput/VoiceMessageInputWrapper.tsx
Outdated
Show resolved
Hide resolved
sravan-s
reviewed
Feb 21, 2023
src/smart-components/Channel/context/hooks/useSendVoiceMessageCallback.ts
Outdated
Show resolved
Hide resolved
sravan-s
reviewed
Feb 21, 2023
src/smart-components/Channel/context/hooks/useSendVoiceMessageCallback.ts
Show resolved
Hide resolved
sravan-s
reviewed
Feb 21, 2023
src/smart-components/Channel/context/hooks/useSendVoiceMessageCallback.ts
Outdated
Show resolved
Hide resolved
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
reviewed
Feb 21, 2023
sravan-s
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HoonBaek This looks like a gigantic amount of work 🙇
HoonBaek
commented
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIKIT-3256
Description Of Changes
Creates
start
, andstop
functionsrecordingLimit
,recordingTime
,recordingFile
, andrecordingStatus
. Recommend using this hook in the customized components.play
, andpause
functionsplaybackTime
,duration
, andplayingStatus
. Recommend using this hook in the customized components.Edits
lamejs
to transcode the audio file to mp3isVoiceMessageEnabled
andvoiceRecord
props to the App,SendbirdProvider
, andMessageInput
components, to turn on/off the voice message recording featurerenderFileUploadIcon
,renderVoiceMessageIcon
, andrenderSendMessageIcon
into theChannel
,ChannelUI
, andMessageInput
componentonVoiceMessageIconClick
props to theMessageInput
componentonBeforeSendVoiceMessage
props to theChannel
componentMetaArray
in theChannel
andThread
modulesAudioOnLined
& new icon-color Primary2 and OnBackground4BUTTON__OK
: 'OK' → Used on the submit button of pop up modalMODAL__VOICE_MESSAGE_INPUT_DISABLED__TITLE_MUTED
: 'You're muted by the operator.' → Used in an alert pop-up modalMODAL__VOICE_MESSAGE_INPUT_DISABLED__TITLE_FROZEN
: 'Channel is frozen.' → Used in an alert pop-up modalVOICE_MESSAGE
: 'Voice Message' → Used in ChannelPreviewItem, QuoteMessage, and MessageSearch to appear that the message type is the voiceTypes Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_