Skip to content

Fix #81: Stop using insecure option by default #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2018
Merged

Fix #81: Stop using insecure option by default #87

merged 1 commit into from
Mar 8, 2018

Conversation

thinkingserious
Copy link
Contributor

Fixes #81

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: security known security issue status: ready for deploy code ready to be released in next deploy status: code review request requesting a community code review or review from Twilio and removed status: code review request requesting a community code review or review from Twilio labels Mar 8, 2018
@codecov
Copy link

codecov bot commented Mar 8, 2018 •
edited
Loading

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files           3        3           
  Lines         170      170           
=======================================
  Hits          148      148           
  Misses         22       22
Impacted Files Coverage Δ
lib/Client.php 84.67% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36693c5...a57b6e2. Read the comment docs.

@thinkingserious thinkingserious merged commit 7f886cb into master Mar 8, 2018
@thinkingserious
Copy link
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
@thinkingserious
Merge pull request sendgrid#87 from sendgrid/81_insecure
599c037 
Fix sendgrid#81: Stop using insecure option by default
@childish-sambino childish-sambino deleted the 81_insecure branch January 16, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: security known security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkingserious