-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking to get your input on some refactoring #42
Looking to get your input on some refactoring #42
Conversation
…s. Non-subscriptable ones are broken after this commit, but there's no test for it. So let's pretend everything's fine.
…efore_return_object_refs
… they are subscriptable
'oldvalue': 'old_value'} | ||
|
||
|
||
def order_unordered(data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used anymore since we switched to ContentHash instead of Pickle.
Hey Victor, Thanks for contributing to DeepDiff and your comments!
Let me know your thoughts. |
I'm gonna close here as we've also got #43 open now and I think I ended up not really using much of my "pre-refactoring" anyway... :) |
Hi Sep,
this is not really a true PR in the sense that I'm not really looking to get it merged on it's own merit. I did perform some refactoring in preparation for additional changes and I'm looking to get your thoughts on this.
The picture is that I'm working on a version of DeepDiff that is able to return object references instead of text (or rather in addition to -- those are really separate features). DeepDiff is an incredibly powerful tool and this will open the door to use it in productive code. This will really help with any scenario where DeepDiff's result is to be processed in some way and not just displayed to the user.
To prepare for this I tried to streamline the result handling process a bit.
I also noticed that DeepDiff and DeepSearch (really cool idea BTW, already helped me a bunch) don't share much code at the moment. What are your thoughts on deriving them from a common base class?
Best,
Victor