Skip to content

Conversation

@GlennGeenen
Copy link

@GlennGeenen GlennGeenen commented Jun 28, 2023

Ran npm audit fix to remove a high risk.

Removed date-fns dependency as it's large for not really being used.

Checklist
  • npm test passes and has 100% coverage

{
"name": "migrate-mongo",
"version": "10.0.0",
"version": "10.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just bug fixing? I think we should update minor version. As we are removing package.

@seppevs
Copy link
Owner

seppevs commented Jan 29, 2025

Feature is in migrate-mongo v12 now

@seppevs seppevs closed this Jan 29, 2025
@nathan-knight
Copy link
Contributor

@seppevs this doesn't seem to be in migrate-mongo v12, the package is still listed as a dependency:

"date-fns": "^2.28.0",
and is still used:
const nowAsString = () => format(now(), "yyyyMMddHHmmss");

Although in the 12.0.0 changelog you credited this PR with removing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants