Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Refactor phred snippets. The int cast is not needed. #2291

Merged

Conversation

Irallia
Copy link
Contributor

@Irallia Irallia commented Dec 4, 2020

This is a follow up of #2290
and connected to seqan/product_backlog#266.
The cast to integer is not needed for a better output. This is automaticly done with the debug_stream.

@Irallia Irallia self-assigned this Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #2291 (951398c) into master (c812a00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2291   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         261      261           
  Lines       10820    10820           
=======================================
  Hits        10624    10624           
  Misses        196      196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c812a00...951398c. Read the comment docs.

@Irallia Irallia requested review from a team and marehr and removed request for a team December 7, 2020 13:20
Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and very nice :))

@marehr marehr requested review from a team and smehringer and removed request for a team December 8, 2020 10:46
Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase though :)

Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the doc/alphabet/refactor_phred_snippets branch from daa509a to 951398c Compare December 9, 2020 14:09
@smehringer smehringer merged commit cdd1e44 into seqan:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants