Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Enable header tests for search module #933

Merged
merged 3 commits into from
May 20, 2019

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Apr 25, 2019

Blocked by xxsds/sdsl-lite#66

Now that the SDSL passes the header tests, we can re-enable the header tests for the search module.

@eseiler eseiler requested a review from smehringer April 25, 2019 10:18
@marehr
Copy link
Member

marehr commented Apr 29, 2019

It seemes that gcc-7 still has linkage problems:

CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-2.dir/seqan3_header_test_files/seqan3/search/algorithm/all-2.cpp.o: In function `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const':
all-2.cpp:(.text+0x10): multiple definition of `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const'
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-1.dir/seqan3_header_test_files/seqan3/search/algorithm/all-1.cpp.o:all-1.cpp:(.text+0x10): first defined here
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-2.dir/seqan3_header_test_files/seqan3/search/algorithm/all-2.cpp.o: In function `sdsl::sorted_stack_support::operator!=(sdsl::sorted_stack_support const&) const':
all-2.cpp:(.text+0xb0): multiple definition of `sdsl::sorted_stack_support::operator!=(sdsl::sorted_stack_support const&) const'
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-1.dir/seqan3_header_test_files/seqan3/search/algorithm/all-1.cpp.o:all-1.cpp:(.text+0xb0): first defined here
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-search-1.dir/seqan3_header_test_files/seqan3/search/algorithm/search-1.cpp.o: In function `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const':
search-1.cpp:(.text+0x10): multiple definition of `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const'

@eseiler
Copy link
Member Author

eseiler commented Apr 30, 2019

Yes, it's blocked by an sdsl PR. I introduced some not-inline functions when I pushed the cereal support.
The PR fixes this (and introduces a header test).

@eseiler eseiler force-pushed the feature/search_header_test branch from 875af72 to 331f858 Compare May 17, 2019 12:58
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #933 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         181      181           
  Lines        6640     6640           
=======================================
  Hits         6402     6402           
  Misses        238      238
Impacted Files Coverage Δ
.../search/algorithm/configuration/max_error_rate.hpp 90% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02a7c2...331f858. Read the comment docs.

@eseiler
Copy link
Member Author

eseiler commented May 17, 2019

@smehringer I fixed the upstream problems, so this is now ready for review

@eseiler eseiler requested review from h-2 and removed request for smehringer May 20, 2019 15:21
@h-2 h-2 merged commit 495f648 into seqan:master May 20, 2019
@eseiler eseiler deleted the feature/search_header_test branch May 27, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants