-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Enable header tests for search module #933
Conversation
It seemes that gcc-7 still has linkage problems: CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-2.dir/seqan3_header_test_files/seqan3/search/algorithm/all-2.cpp.o: In function `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const':
all-2.cpp:(.text+0x10): multiple definition of `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const'
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-1.dir/seqan3_header_test_files/seqan3/search/algorithm/all-1.cpp.o:all-1.cpp:(.text+0x10): first defined here
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-2.dir/seqan3_header_test_files/seqan3/search/algorithm/all-2.cpp.o: In function `sdsl::sorted_stack_support::operator!=(sdsl::sorted_stack_support const&) const':
all-2.cpp:(.text+0xb0): multiple definition of `sdsl::sorted_stack_support::operator!=(sdsl::sorted_stack_support const&) const'
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-all-1.dir/seqan3_header_test_files/seqan3/search/algorithm/all-1.cpp.o:all-1.cpp:(.text+0xb0): first defined here
CMakeFiles/seqan3_header_test--seqan3-search-algorithm-search-1.dir/seqan3_header_test_files/seqan3/search/algorithm/search-1.cpp.o: In function `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const':
search-1.cpp:(.text+0x10): multiple definition of `sdsl::sorted_stack_support::operator==(sdsl::sorted_stack_support const&) const' |
Yes, it's blocked by an sdsl PR. I introduced some not-inline functions when I pushed the cereal support. |
875af72
to
331f858
Compare
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 181 181
Lines 6640 6640
=======================================
Hits 6402 6402
Misses 238 238
Continue to review full report at Codecov.
|
@smehringer I fixed the upstream problems, so this is now ready for review |
Blocked by xxsds/sdsl-lite#66Now that the SDSL passes the header tests, we can re-enable the header tests for the search module.