Fix SequanaConfig class (regression bug). #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddesvillechabrol
approved these changes
Sep 1, 2021
cokelaer
force-pushed
the
fix_config_update
branch
from
9e18cb6 to
d553d11
Compare
| pm.teardown() | ||
| try: | ||
| pm.teardown() | ||
| except: |
There was a problem hiding this comment.
Tu sais ce que ça peut raise le teardown dans le cadre du test ?
There was a problem hiding this comment.
non, l'idée ici c'était juste de supprimer le Makefile qui est créé si ca plante ou non et du coup j'ai mis un try/except par contre, pas de failure attendu. J'ai ajouté Exception
cokelaer
force-pushed
the
fix_config_update
branch
from
d553d11 to
98eee7b
Compare
cokelaer
force-pushed
the
fix_config_update
branch
from
98eee7b to
afdd299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix test_complete adding a try/except in sequana_pipetools/snaketools/sequana_config