This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(migration): Add uuids to documents that don't have them #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingDive
changed the title
WIP: feat(migration): Add uuids to documents that don't have them
feat(migration): Add uuids to documents that don't have them
Apr 22, 2024
kulla
suggested changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodingDive Thx! ❤️ I am going to resolve the conflicts myself and deploy this migration in staging
For deployment: serlo/infra#48 (I have a blocker asking something @hugotiburtino ) |
It seems you solved by yourself. Anyway, it is deployed now in staging |
kulla
approved these changes
Apr 25, 2024
chore: Add support when MySQL is not running in local dir
Trying to find the bug of why it doesn't apply to absolutely all plugins. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #266. Could not run the migrations yet and will probably need some guidance on how I could do so.
I followed the readme here for starting the db, but I can see that my image is called
serlo-mysql-database-mysql
while this repo expects simplymysql
running in a container.Error I'm receiving when trying to run
yarn migrate:run src/20240419175700-add-uuid-to-editor-documents.ts
isservice "mysql" is not running container #1
Above error is now fixed due to Kulla helping me. I tested the script and it seems to work quite good!
Editor state before
Editor state after
I diffed the states with a few entities and it seems to have added all the uuids correctly. When reviewing, please double check, that I only added ids where they should be added and that it won't cause issues in the frontend when diffing old vs new revisions.