Fix: limit sqs,kinesis permissions #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horike37
approved these changes
Aug 17, 2019
There was a problem hiding this comment.
@erezrokah
Thank you for this again 👍 Totally agree with @theburningmonk suggestion.
I believe this is due to the serverless deploy command running from the root directory for all the >tests, so the .serverless directory got deleted/overwritten occasionally.
The solution was to set a different working directory for each test using the cwd option of the >execSync function.
Make sense. Yes, the framework core don't have a functionality to change the directory, so using the option would be best way.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Per @theburningmonk suggestion in the issue above and here.
Took longer than expected as I added more integrations tests and ran into a stability issue with the tests - they were passing all the time when running with one worker, but failing sometimes with multiple workers.
I believe this is due to the
serverless deploycommand running from the root directory for all the tests, so the.serverlessdirectory got deleted/overwritten occasionally.The solution was to set a different working directory for each test using the
cwdoption of theexecSyncfunction.I searched for a way to change the default
.serverlessdirectory but from looking at the framework code it seems hard-coded.Please let me know if the integration tests explanation makes sense :)