-
Notifications
You must be signed in to change notification settings - Fork 81
Feature/support s3 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support s3 #22
Conversation
# Conflicts: # package-lock.json
Sorry for the self promoting, but I wrote a library that might help with the integration tests. You can assert an S3 object, and delete objects as well. e.g. const { default: awsTesting } = require('aws-testing-library/lib/chai')
const chai = require('chai')
chai.use(awsTesting)
const { expect } = chai
const { clearAllObjects } = require('aws-testing-library/lib/utils/s3')
afterAll(async () => {
await clearAllObjects('us-east-1', bucket)
removeService(stage, config)
})
it('should get correct response from s3 put endpoint', async () => {
// test setup, act
// test assert
await expect({
region: 'us-east-1',
bucket,
timeout: 0,
pollEvery: 0
}).to.have.object(key, Buffer.from(JSON.stringify({ message: 'test' })))
})
it('should get correct response from s3 delete endpoint', async () => {
// test setup, act
// test assert
await expect({
region: 'us-east-1',
bucket,
timeout: 0,
pollEvery: 0
}).to.not.have.object(key)
}) |
@theburningmonk |
@horike37 of course, I was just thinking that I forgot to update README on all my PRs yesterday! |
@erezrokah thanks for the offer, but I'm not doing too much with the AWS SDK in this project so I'd rather not bring in another library for now. I'll check it out for future projects/PRs. |
@horike37 done, README updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theburningmonk
Thanks for updating! Great to see working fine 👍
LGTM.
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #9
Besides adding support for S3 I made some small changes as well:
getKinesisMethodIntegration
andgetMethodResponses