Skip to content

Conversation

pmuens
Copy link
Contributor

@pmuens pmuens commented Aug 4, 2016

Corresponding issue: #1446

This PR implements a . printing while loading (e.g. checking if the stack is created).
This will reduce the used terminal real estate dramatically.

/cc @eahefnawy @flomotlik

@eahefnawy
Copy link
Contributor

The way I was imagining it is that it's just 3 dots maximum and then starts from scratch. Which is much more pretty imo. The way this seems to be setup is that it'll print a . every 5 second, and after 60 seconds (average creation time) you'll end up with 12 dots.

I guess it's not a big deal though. I'm not a big fan of using dots anyway 😛

@pmuens
Copy link
Contributor Author

pmuens commented Aug 4, 2016

😆 yes, true. Not the most pretty solution so far but still better than printing the whole message Every time. Maybe we can stick with this for the beginning and improve in the future.

@flomotlik
Copy link
Contributor

Yup agreed to everything. Much better than the whole output. Can still be improved, but not a big priority imho beyond what we have here. GTM from my side

@eahefnawy eahefnawy merged commit ef1ac84 into master Aug 4, 2016
@eahefnawy eahefnawy deleted the print-a-dot-while-loading branch August 4, 2016 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants