Use redirect property on HTTP and OpenAPI calls

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>

Author: mcruzdev

impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/AbstractHttpExecutorBuilder.java

@@ -15,12 +15,16 @@
  */
 package io.serverlessworkflow.impl.executors.http;
 
+import io.serverlessworkflow.impl.TaskContext;
 import io.serverlessworkflow.impl.WorkflowApplication;
+import io.serverlessworkflow.impl.WorkflowError;
+import io.serverlessworkflow.impl.WorkflowException;
 import io.serverlessworkflow.impl.WorkflowFilter;
 import io.serverlessworkflow.impl.WorkflowUtils;
 import io.serverlessworkflow.impl.WorkflowValueResolver;
 import jakarta.ws.rs.HttpMethod;
 import jakarta.ws.rs.client.WebTarget;
+import jakarta.ws.rs.core.Response;
 import java.net.URI;
 import java.util.Map;
 import java.util.Optional;
@@ -35,13 +39,18 @@ abstract class AbstractHttpExecutorBuilder {
   protected boolean redirect;
 
   protected static RequestSupplier buildRequestSupplier(
-      String method, Object body, WorkflowApplication application) {
+      String method, Object body, boolean redirect, WorkflowApplication application) {
 
     switch (method.toUpperCase()) {
       case HttpMethod.POST:
         WorkflowFilter bodyFilter = WorkflowUtils.buildWorkflowFilter(application, body);
         return (request, w, t, node) -> {
           HttpModelConverter converter = HttpConverterResolver.converter(w, t);
+          Response res =
+              request.buildPost(converter.toEntity(bodyFilter.apply(w, t, node))).invoke();
+
+          applyRedirectValidation(redirect, t, res);
+
           return w.definition()
               .application()
               .modelFactory()
@@ -51,11 +60,38 @@ protected static RequestSupplier buildRequestSupplier(
         };
       case HttpMethod.GET:
       default:
-        return (request, w, t, n) ->
-            w.definition()
-                .application()
-                .modelFactory()
-                .fromAny(request.get(HttpConverterResolver.converter(w, t).responseType()));
+        return (request, w, t, n) -> {
+          Response res = request.buildGet().invoke();
+          applyRedirectValidation(redirect, t, res);
+
+          return w.definition()
+              .application()
+              .modelFactory()
+              .fromAny(res.readEntity(HttpConverterResolver.converter(w, t).responseType()));
+        };
+    }
+  }
+
+  private static void applyRedirectValidation(boolean redirect, TaskContext t, Response response) {
+    Response.Status.Family statusFamily = response.getStatusInfo().getFamily();
+    boolean isSuccess = statusFamily.equals(Response.Status.Family.SUCCESSFUL);
+    boolean isRedirect = statusFamily.equals(Response.Status.Family.REDIRECTION);
+
+    boolean valid = redirect ? (isSuccess || isRedirect) : isSuccess;
+    if (!valid) {
+      String expectedRange = redirect ? "200-399" : "200-299";
+      throw new WorkflowException(
+          WorkflowError.communication(
+                  response.getStatus(),
+                  t,
+                  new RedirectValidationException(
+                      String.format(
+                          "The property 'redirect' is %s but received status %d (%s); expected status in the %s range",
+                          redirect,
+                          response.getStatus(),
+                          response.getStatusInfo().getReasonPhrase(),
+                          expectedRange)))
+              .build());
     }
   }
 

impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/CallableTaskHttpExecutorBuilder.java

@@ -63,7 +63,10 @@ public void init(CallHTTP task, WorkflowDefinition definition, WorkflowMutablePo
     }
     this.requestFunction =
         buildRequestSupplier(
-            httpArgs.getMethod().toUpperCase(), httpArgs.getBody(), definition.application());
+            httpArgs.getMethod().toUpperCase(),
+            httpArgs.getBody(),
+            httpArgs.isRedirect(),
+            definition.application());
   }
 
   @Override

impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/HttpExecutorBuilder.java

@@ -83,7 +83,7 @@ public HttpExecutor build(String uri) {
   }
 
   public HttpExecutor build(WorkflowValueResolver<URI> uriSupplier) {
-    this.requestFunction = buildRequestSupplier(method, body, definition.application());
+    this.requestFunction = buildRequestSupplier(method, body, redirect, definition.application());
     this.targetSupplier =
         pathSupplier == null
             ? getTargetSupplier(uriSupplier)

impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/RedirectValidationException.java

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2020-Present The Serverless Workflow Specification Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.serverlessworkflow.impl.executors.http;
+
+public class RedirectValidationException extends RuntimeException {
+  private static final long serialVersionUID = 1L;
+
+  public RedirectValidationException(String message) {
+    super(message);
+  }
+}

impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java

@@ -202,8 +202,9 @@ public void testOpenAPIBearerQueryInlinedBodyWithNegativeResponse() throws Excep
                     .asMap()
                     .orElseThrow());
     assertInstanceOf(WorkflowException.class, exception.getCause());
-    assertTrue(exception.getMessage().contains("status=409"));
-    assertTrue(exception.getMessage().contains("title=HTTP 409 Client Error"));
+    assertTrue(
+        exception.getMessage().contains("property 'redirect' is true but received status 409"));
+    assertTrue(exception.getMessage().contains("409 (Client Error)"));
 
     RecordedRequest restRequest = restServer.takeRequest();
     assertEquals("POST", restRequest.getMethod());

impl/test/src/test/resources/workflows-samples/openapi/project-post-positive.yaml

@@ -21,4 +21,5 @@ do:
           validateOnly: false
           notifyMembers: true
           lang: en
-          Authorization: "Bearer eyJhbnNpc2l0b3IuYm9sdXMubWFnbnVz"
+          Authorization: "Bearer eyJhbnNpc2l0b3IuYm9sdXMubWFnbnVz"
+        redirect: true

impl/test/src/test/resources/workflows-samples/try-catch-retry-inline.yaml

@@ -11,6 +11,7 @@ do:
             with:
               method: get
               endpoint: http://localhost:9797
+              redirect: true
       catch:
         errors:
           with:

impl/test/src/test/resources/workflows-samples/try-catch-retry-reusable.yaml

@@ -21,6 +21,7 @@ do:
             with:
               method: get
               endpoint: http://localhost:9797
+              redirect: true
       catch:
         errors:
           with: