Removed warn-log stop_parsing not implemented, full speed ahead!
#322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any reason this has not been merged? It would be useful, those warning messages are annoying. |
|
@bors-servo: r+ |
|
📌 Commit fa23013 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 3, 2018
Removed warn-log `stop_parsing not implemented, full speed ahead!` As mentioned in #219, `stop_parsing` was assumed to be useless. It still triggers in my project, hence considered removing it. Hopefully this PR is okay, despite already being assigned to @nox. I simply encountered it a few days ago and decided to make the move, as this issue seems to be there for a while, I preferred to do it myself than bothering anyone for such a small fix : ) Not sure if `"FIXME: </script> not fully implemented"` can be removed as well, if so, just inform me and I will change that as well!
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #219,
stop_parsingwas assumed to be useless. It still triggers in my project, hence considered removing it.Hopefully this PR is okay, despite already being assigned to @nox. I simply encountered it a few days ago and decided to make the move, as this issue seems to be there for a while, I preferred to do it myself than bothering anyone for such a small fix : )
Not sure if
"FIXME: </script> not fully implemented"can be removed as well, if so, just inform me and I will change that as well!