Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd more documentation #329
Conversation
|
Good additions! |
| let local_names = Path::new(&env::var("CARGO_MANIFEST_DIR").unwrap()).join("local_names.txt"); | ||
| let mut local_names_atom = string_cache_codegen::AtomType::new("LocalName", "local_name!"); | ||
| for line in BufReader::new(File::open(&local_names).unwrap()).lines() { | ||
| let local_name = line.unwrap(); | ||
| local_names_atom.atom(&local_name); | ||
| local_names_atom.atom(&local_name.to_ascii_lowercase()); | ||
| } | ||
| local_names_atom.write_to(&mut generated).unwrap(); | ||
| local_names_atom | ||
| .with_macro_doc("Takes a local name as a string and returns its key in the a string cache.") |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| .atoms(NAMESPACES.iter().map(|&(_prefix, url)| url)) | ||
| .write_to(&mut generated) | ||
| .unwrap(); | ||
|
|
||
| writeln!(generated, "#[macro_export] macro_rules! ns {{").unwrap(); | ||
| // T |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -119,6 +144,7 @@ impl QualName { | |||
| } | |||
| } | |||
|
|
|||
| /// Take a reference as an `ExpandedName`, dropping the unresolved prefix. | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
derekdreery
Nov 23, 2017
Author
I've changed this to "Take a reference of self". Do you think this is clear enough, or would you rather something else?
This comment has been minimized.
This comment has been minimized.
jdm
Nov 23, 2017
Member
I think Return this qualified name as an ExpandedName without the unresolved prefix. is more clear.
This comment has been minimized.
This comment has been minimized.
| //! See the [document object model article on wikipedia][dom wiki] for more information. | ||
| //! | ||
| //! This implementation stores the information associated with each node once, and then hands out | ||
| //! refs to children. The nodes themselves are reference-counted to avoid copy - you can create a |
This comment has been minimized.
This comment has been minimized.
|
This is blocked on a new release of string-cache-codegen and dependency bumps. |
|
|
|
@derekdreery Great work, but it seems some upstream changes, kinda broke it. |
|
Yeah I will update
…On 12 Dec 2017 14:38, "Ygg01" ***@***.***> wrote:
@derekdreery <https://github.com/derekdreery> Great work, but it seems
some upstream changes, kinda broke it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#329 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABU-XmW1YvpPoCxN6l6Gqmw-PUUKf0S-ks5s_o_0gaJpZM4Qnsu9>
.
|
|
I'm trying to tidy up old pull requests. I've rebased off latest master (as of 2018-07-25). I think this is ready for review again. |
|
@bors-servo r+ |
|
|
Add more documentation I recently submitted a PR to add documentation. This PR adds some more. Note it won't merge as-is because it relies on PR [#199 in servo/string-cache]. [#199 in servo/string-cache]: servo/string-cache#199
|
|
derekdreery commentedNov 22, 2017
I recently submitted a PR to add documentation. This PR adds some more.
Note it won't merge as-is because it relies on PR #199 in servo/string-cache.