deps: bump encoding_rs to 0.8 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @SimonSapin |
|
This looks good to me. Thanks @ignatenkobrain :) @bors-servo r+ |
|
📌 Commit 14cdede has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 10, 2019
deps: bump encoding_rs to 0.8 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/227) <!-- Reviewable:end -->
|
💔 Test failed - checks-travis |
|
The failure is not your fault. I opened #238 to address it, and we can merge after that lands. |
bors-servo
pushed a commit
that referenced
this pull request
Feb 11, 2019
Fix nightly warnings and errors. This will allow #227 to merge. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/238) <!-- Reviewable:end -->
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Feb 11, 2019
deps: bump encoding_rs to 0.8 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/227) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is