Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak at-rule parsing API to allow a single at-rule to be block or blockless. #287

Merged
merged 2 commits into from Sep 3, 2021

Conversation

emilio
Copy link
Member

@emilio emilio commented Sep 1, 2021

This is needed for @layer, which can be block or blockless.

…ock-less.

This is needed for @layer, which can be block or blockless.
@emilio
Copy link
Member Author

emilio commented Sep 1, 2021

r? @SimonSapin / @hiikezoe / @boris

Copy link

@BorisChiou BorisChiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall looks good to me. Based on the usage of @layer rule, this update makes sense to me.

@emilio
Copy link
Member Author

emilio commented Sep 3, 2021

@bors-servo r=BorisChiou

@bors-servo
Copy link
Contributor

📌 Commit 13c7869 has been approved by BorisChiou

@bors-servo
Copy link
Contributor

⌛ Testing commit 13c7869 with merge b0e5a9c...

bors-servo added a commit that referenced this pull request Sep 3, 2021
Tweak at-rule parsing API to allow a single at-rule to be block or blockless.

This is needed for @layer, which can be block or blockless.
@emilio
Copy link
Member Author

emilio commented Sep 3, 2021

Ah, I guess travis is no more. We'll have to update this to github actions sooner rather than later.

@emilio emilio merged commit b8ae0a3 into master Sep 3, 2021
@emilio emilio deleted the blockless branch September 3, 2021 09:04
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 3, 2021
@bors-servo
Copy link
Contributor

💥 Test timed out

spinda pushed a commit to PLSysSec/cachet-firefox that referenced this pull request Sep 8, 2021
Loirooriol pushed a commit to Loirooriol/servo that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants