-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get A+ on Mozilla Observatory for servo.org #473
Comments
Something that caught my eye is that we are failing the cookie test, even though we ourselves don't set any cookies. It turns out CloudFlare is adding a |
Oops, misclick. |
Bonus points if you utilize the actual |
I have started investigating this issue, and this is my current understanding:
Are there other subdomains I haven't found? |
@jarondl The only other subdomain I know of is (I think download.servo.org is on S3 with some redirection magic, not GH pages.) We are planning to add https to build.servo.org; see #423 for the tracking issue. Even while that is in progress, we can still work on adding the appropriate headers to Nginx; it's not necessary to go from ~0 to 100% in one step. I can assign you if you would like to work on this. |
There is also |
@jarondl It's yours, please ask if you have any questions. |
@jarondl How is this going? Anything that I can clear up for you? |
Add some headers to `build.servo.org` to improve our Mozilla Observatory score. The helps the cause of servo#473, by raising our score from F (0) to a whopping B- (65). The testing is still basic, the docker-observatory based testing will go in a different PR. To get to an A+ we must first implement https. This is the local observatory report: Score Rule Description -20 redirection Does not redirect to an https site. -20 strict-transport-security HTTP Strict Transport Security (HSTS) header cannot be set for sites not available over https. -5 contribute Contribute.json file missing from root of website. 5 content-security-policy Content Security Policy (CSP) implemented without 'unsafe-inline' or 'unsafe-eval'. 5 x-frame-options X-Frame-Options (XFO) implemented via the CSP frame-ancestors directive. Score: 65 Grade: B-
Hi @aneeshusa , The headers and the simple checks were easy, just reading through the docs to see what applies. Basically, both homu and buildbot don't use external resources, so it's very easy. Running the Mozilla observatory locally with localhost and custom ports was more involved. I have managed it locally, but I want a more robust solution before including that in the tests. It does, however, require docker and docker-compose. Both are available on travis, but not on our Vagrant setup. Do you think that's a reasonable dependency? |
Scan results: https://observatory.mozilla.org/analyze.html?host=servo.org
This should mostly entail adding headers via Ngnix.
Files:
nginx/default
Add a new test file(s) in the
tests/sls/nginx
dir. See the test added in #375 for an example.The text was updated successfully, but these errors were encountered: