Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the "storageevent" argument to Document::createEvent #10736

Closed
Ms2ger opened this issue Apr 20, 2016 · 2 comments
Closed

Implement the "storageevent" argument to Document::createEvent #10736

Ms2ger opened this issue Apr 20, 2016 · 2 comments
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 20, 2016 •
edited

Blocks #2185, #10734.

This will involve writing a new_uninitialized function on StorageEvent and calling it from Document::CreateEvent.
@Ms2ger Ms2ger added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature. labels Apr 20, 2016
@mskrzypkows
Copy link

I'd like to take this one.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 21, 2016

Go for it!

@jdm jdm added the C-assigned There is someone working on resolving the issue label Apr 21, 2016
mskrzypkows pushed a commit to mskrzypkows/servo that referenced this issue Apr 25, 2016
"storageevent" argument for Document::createEvent
7ed208b 
Fixes  servo#10736
mskrzypkows pushed a commit to mskrzypkows/servo that referenced this issue Apr 25, 2016
"storageevent" argument for Document::createEvent
6187ee6 
Fixes  servo#10736
@mskrzypkows mskrzypkows mentioned this issue Apr 25, 2016
Merged
bors-servo pushed a commit that referenced this issue Apr 25, 2016
Auto merge of #10831 - mskrzypkows:storageevent, r=Ms2ger
8bf732e 
"storageevent" argument for Document::createEvent

Fixes  #10736

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10831)
<!-- Reviewable:end -->
jaysonsantos pushed a commit to jaysonsantos/servo that referenced this issue May 12, 2016
@jaysonsantos
"storageevent" argument for Document::createEvent
1a1fde2 
Fixes  servo#10736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @Ms2ger @mskrzypkows